api: enable savepoints for transactions #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use nested transactions in our tests to roll back the changes made in the tests. Doing this without enabling savepoints is deprecated and will be removed in doctrine/orm 3.0. This adds 2 queries to every request in the tests: - SAVEPOINT DOCTRINE2_SAVEPOINT_2 - RELEASE SAVEPOINT DOCTRINE2_SAVEPOINT_2 closes ecamp#3741
BacLuc
force-pushed
the
api-enable-savepoints
branch
from
ae6d606
to
07e1a30
Compare
carlobeltrame
approved these changes
Sep 25, 2023
I think it probably adds a |
Sorry, did update the commit message, but not the PR description. |
usu
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use nested transactions in our tests to roll back the changes made in the tests.
Doing this without enabling savepoints is deprecated and will be removed in doctrine/orm 3.0.
This adds 2 queries to every request in the tests:
closes #3741