api: upgrade api-platform/core to 3.2.1 #3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BacLuc
force-pushed
the
api-upgrade-api-platform
branch
2 times, most recently
from
1f735a2
to
21b93e2
Compare
usu
approved these changes
Oct 21, 2023
BacLuc
force-pushed
the
api-upgrade-api-platform
branch
from
21b93e2
to
3ac141e
Compare
BacLuc
force-pushed
the
api-upgrade-api-platform
branch
from
3ac141e
to
f7506bf
Compare
carlobeltrame
approved these changes
Nov 10, 2023
Comment on lines
-635
to
-642
| _links: | ||
| properties: | ||
| self: | ||
| properties: | ||
| href: | ||
| format: iri-reference | ||
| type: string | ||
| type: object |
There was a problem hiding this comment.
Any idea why this vanished?
There was a problem hiding this comment.
Sadly no, but it doesn't affect us.
I can raise an issue with api platform/openapi later
update api-plattform-allow-null-links.patch because of whitespace changes: create a file ...._old.php with the repository version of the file then: git diff --no-index api/vendor/api-platform/core/src/Hal/Serializer/ItemNormalizer_old.php api/vendor/api-platform/core/src/Hal/Serializer/ItemNormalizer.php Add docs_formats because this must now be configured separately to enable hal. Do not support json as docs format, because this renders an error. (It returns a 200 response, but the returned json contains a stacktrace).
BacLuc
force-pushed
the
api-upgrade-api-platform
branch
from
f7506bf
to
3032bd4
Compare
BacLuc
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3933
update api-plattform-allow-null-links.patch because of whitespace changes: create a file ...._old.php with the repository version of the file
then: git diff --no-index api/vendor/api-platform/core/src/Hal/Serializer/ItemNormalizer_old.php api/vendor/api-platform/core/src/Hal/Serializer/ItemNormalizer.php
Add docs_formats because this must now be configured separately to enable hal.
Do not support json as docs format, because this renders an error. (It returns a 200 response, but the returned json contains a stacktrace).