Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(api): use pcov for code coverage #4096

Merged
merged 1 commit into from
Nov 12, 2023
Merged

chore(api): use pcov for code coverage #4096

merged 1 commit into from
Nov 12, 2023

Conversation

usu
Copy link
Member

@usu usu commented Nov 12, 2023 •
edited
Loading

API tests run 2-3x faster compared to coverage by xdebug

On my fork:

BacLuc
BacLuc approved these changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@BacLuc BacLuc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.
And really simple.
I did not know that the coverage measurement takes that long.

manuelmeister
manuelmeister approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@manuelmeister manuelmeister added this pull request to the merge queue Nov 12, 2023
Merged via the queue into ecamp:devel with commit 1ce1996 Nov 12, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelmeister manuelmeister manuelmeister approved these changes

@BacLuc BacLuc BacLuc approved these changes

@carlobeltrame carlobeltrame Awaiting requested review from carlobeltrame

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usu @BacLuc @manuelmeister