frontend: load all dayResponsibles in one request in Dashboard.vue #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
carlobeltrame
requested changes
Nov 20, 2023
…d.vue By loading the days in one request per period which embed the dayResponsibles. When loading the dayResponsibles directly, there was still a request per day for the dayResponsibles. This makes the loading of Dashboard.vue faster. It also may reduce the e2e test failures of the firefox tests due to: "Request aborted" errors after the test is finished. (The test did not wait for the dayResponsibles to be loaded and then aborted the load which lead to the requests being aborted.)
That it's possible to load all days of a camp in one request.
BacLuc
force-pushed
the
dashboard-load-dayresponsibles-in-one-request
branch
from
f737f3b
to
c6e9dc8
Compare
BacLuc
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
carlobeltrame
approved these changes
Nov 20, 2023
|
@manuelmeister |
manuelmeister
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frontend: load all dayResponsibles in one request per period Dashboard.vue
By loading the days in one request per period which embed the dayResponsibles.
When loading the dayResponsibles directly, there was still
a request per day for the dayResponsibles.
This makes the loading of Dashboard.vue faster.
It also may reduce the e2e test failures of the firefox tests due to:
"Request aborted" errors after the test is finished.
(The test did not wait for the dayResponsibles to be loaded and then
aborted the load which lead to the requests being aborted.)
frontend/api: add camp filter on days for Dashboard.vue
That it's possible to load all days of a camp in one request.
Related to #4010