-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary function calls and this.api bindings in router.js #5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmeister
added
deploy!
Creates a feature branch deployment for this PR
test-flaky-e2e!
Add this label to a PR to run e2e tests multiple times
labels
Apr 20, 2024
manuelmeister
temporarily deployed
to
feature-branch
April 20, 2024 16:58
— with
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
usu
approved these changes
Apr 21, 2024
manuelmeister
requested review from
pmattmann,
BacLuc,
carlobeltrame and
simfeld
April 21, 2024 14:04
manuelmeister
had a problem deploying
to
feature-branch
April 21, 2024 14:07
— with
GitHub Actions
Error
manuelmeister
had a problem deploying
to
feature-branch
April 21, 2024 14:15
— with
GitHub Actions
Failure
manuelmeister
had a problem deploying
to
feature-branch
April 21, 2024 14:25
— with
GitHub Actions
Failure
manuelmeister
had a problem deploying
to
feature-branch
April 21, 2024 14:29
— with
GitHub Actions
Failure
manuelmeister
had a problem deploying
to
feature-branch
April 21, 2024 14:35
— with
GitHub Actions
Failure
manuelmeister
had a problem deploying
to
feature-branch
April 21, 2024 14:36
— with
GitHub Actions
Failure
manuelmeister
had a problem deploying
to
feature-branch
April 21, 2024 14:44
— with
GitHub Actions
Failure
manuelmeister
had a problem deploying
to
feature-branch
April 21, 2024 15:07
— with
GitHub Actions
Failure
manuelmeister
added
deploy!
Creates a feature branch deployment for this PR
and removed
deploy!
Creates a feature branch deployment for this PR
labels
Apr 21, 2024
manuelmeister
had a problem deploying
to
feature-branch
April 21, 2024 15:35
— with
GitHub Actions
Failure
manuelmeister
had a problem deploying
to
feature-branch
April 21, 2024 20:03
— with
GitHub Actions
Failure
BacLuc
added
deploy!
Creates a feature branch deployment for this PR
and removed
deploy!
Creates a feature branch deployment for this PR
labels
Apr 22, 2024
BacLuc
approved these changes
Apr 27, 2024
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deploy!
Creates a feature branch deployment for this PR
test-flaky-e2e!
Add this label to a PR to run e2e tests multiple times
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also solves the problem, where you get an error when you delete the category in the admin view
Fixes #4966