Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add offline message #5026

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Add offline message #5026

merged 2 commits into from
Apr 25, 2024

Conversation

manuelmeister
Copy link
Member

@manuelmeister manuelmeister commented Apr 20, 2024 •
edited
Loading

Currently it is not fully noticeable if you're offline, as our store still delivers.

@manuelmeister manuelmeister added the deploy! Creates a feature branch deployment for this PR label Apr 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 20, 2024 •
edited
Loading

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

usu
usu approved these changes Apr 21, 2024
View reviewed changes
Copy link
Member

@usu usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also be ok to put this more prominently at the top instead of at the bottom.

@manuelmeister manuelmeister added this pull request to the merge queue Apr 25, 2024
Merged via the queue into ecamp:devel with commit f6ad57f Apr 25, 2024
32 checks passed
This was referenced Apr 28, 2024
Merged
Merged
@manuelmeister manuelmeister deleted the feature/offline-info branch May 15, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmattmann pmattmann pmattmann approved these changes

@usu usu usu approved these changes

@BacLuc BacLuc Awaiting requested review from BacLuc

@simfeld simfeld Awaiting requested review from simfeld

@carlobeltrame carlobeltrame Awaiting requested review from carlobeltrame

Assignees
No one assigned
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manuelmeister @usu @pmattmann @carlobeltrame