Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract API store into separate package #616

Merged

Conversation

carlobeltrame
Copy link
Member

@carlobeltrame carlobeltrame commented Nov 10, 2020

@carlobeltrame carlobeltrame force-pushed the extract-api-store-into-separate-package branch from b3ea578 to f957737 Compare November 11, 2020 08:35
@carlobeltrame carlobeltrame marked this pull request as ready for review November 11, 2020 13:43
frontend/src/plugins/auth.js Outdated Show resolved Hide resolved
@usu
Copy link
Member

usu commented Nov 11, 2020

Coole Sache, danke vielmals 👏
Generell einverstanden, ein paar kleinere Kommentare/Fragen oben.

@carlobeltrame
Copy link
Member Author

Habe es jetzt noch Nuxt-fähig gemacht und in den print service eingebaut. Es entstehen dort aber noch Konsolen-Warnungen, die den Seitentitel bei der Print Preview auf "An error occurred" ändern. Noch nicht perfekt, aber immerhin kann man Daten abrufen.

Copy link
Member

@pmattmann pmattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top! Danke.

frontend/src/plugins/auth.js Show resolved Hide resolved
@carlobeltrame carlobeltrame force-pushed the extract-api-store-into-separate-package branch from 65b8c3d to abfead2 Compare November 13, 2020 20:19
@pmattmann pmattmann merged commit ec6bba8 into ecamp:devel Nov 13, 2020
@carlobeltrame carlobeltrame deleted the extract-api-store-into-separate-package branch November 13, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vuex API Store als eigenes NPM Package extrahieren
3 participants