Add experimental Alpine support #80
Conversation
There was a problem hiding this comment.
Thanks for your contribution, I have never been a big user of anything other than Debian so I have never really looked into supporting other systems as I am not super familiar with them. I'm happy to support once implemented though.
Is this only applicable to Alpine, or would it be able to extend to pretty much all OpenRC based systems?
As a side note I have not tested these changes yet, but will. I don't think there is a easy way to implement tests in the same way as I have currently as I am using a Raspberry Pi Lite image as my testing ground. I will look into a way to implement testing for this platform once merged.
EDIT:
Also can you follow the instructions in the DCO error to sign-off your commits.
|
Sorry for all the trouble. I'm not a bash expert and this is my first time creating a pull request. I'm not sure how to deal with the sign-off though. I'm trying to follow the instructions but it seems like i have to manually merge everything again? |
Signed-off-by: Jonathan Vermeulen <jmavermeulen@gmail.com>
|
Okay fixed the signing issue. Thanks Ethan for you help on that! |
Signed-off-by: flavorplus <flavorplus@users.noreply.github.com>
Signed-off-by: flavorplus <flavorplus@users.noreply.github.com>
|
Would be willing to merge this @ecdye? |
There was a problem hiding this comment.
Almost ready, can you update the README file with information about experimental Alpine support, and then I think we are ready to merge.
Try to just add on to the existing documentation by providing alternative commands to start and stop in Alpine and things like that. It makes it easier to track changes that add new functionality if it is documented and implemented all in one PR.
Signed-off-by: flavorplus <flavorplus@users.noreply.github.com>
Signed-off-by: flavorplus <flavorplus@users.noreply.github.com>
Hi!
I’ve been working on getting this running on Alpine! Everything works great so far and is rebased on your latest commits. I haven’t written any tests yet as I don’t know how… Would it be interesting to add Alpine support to the main repo?