Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a reblog functionality into reblogScreen #2720

Merged
merged 18 commits into from
May 16, 2024
Merged

add a reblog functionality into reblogScreen #2720

merged 18 commits into from
May 16, 2024

Conversation

moazzambukhari
Copy link
Contributor

@moazzambukhari moazzambukhari commented Jul 14, 2023

What does this PR?

add a reblog functionality into reblogScreen"
add onRefresh on reblog screen to get own reblog
add params in reblog route

Where should the reviewer start?

  • reblogScreen
  • postCardActionPanel

Steps to reproduce

Issue number

#2720

Screenshots/Video

Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good so far... please push an update whenever you are done with refresh login

Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noumantahir noumantahir self-requested a review May 16, 2024 09:09
@noumantahir
Copy link
Collaborator

noumantahir commented May 16, 2024

@feruzm can be merged

Screen.Recording.2024-05-16.at.14.10.02.mov

Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good to merge

@noumantahir
Copy link
Collaborator

Adde support for delete/undo reblog

NOTE: I had to discard support for hsClient's reblog method in favour of raw custom_json based transaction with hive signer as well, as reblog did not have support for delete parameter. Something that might be valuable for future reference to be aware of.

Screen.Recording.2024-05-16.at.17.17.46.mov

Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit 06deb8e into development May 16, 2024
@feruzm feruzm deleted the mb/reblog branch May 16, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants