Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Honor prefers-color-scheme and change theme cookie lifespan #603

Closed
mciszczon opened this issue Aug 13, 2021 · 2 comments
Closed

Comments

@mciszczon
Copy link

I have a suggestion to enhance the Ecency browser app by either (or both) making it honor the prefers-color-scheme CSS media to automatically turn on the night mode, even when a cookie for that is not set.

Another proposition from me is to extend the lifespan of theme cookie. Currently it's a session cookie only, so once I restart the browser (or restart the PC, or reboot into a different OS) I have to go and change the theme again. Very frustrating. IMHO the expires value could be set to something arbitrarily high, like half a year or one year maybe.

I could theoretically do a PR with these, as these two changes should be no-brainers, but:

  1. I am not sure whether these changes would be a gladly welcomed additions.
  2. At this time I lack the free time to get to this.

So I am leaving it here for consideration, hoping for a feedback :)

@feruzm
Copy link
Member

feruzm commented Aug 13, 2021

@mciszczon looks like a great additions, feel free to do a PR, of course we will consider and happy to see you contribute, in same PR please add your username in contributors.json so you will be listed in https://ecency.com/contributors. If any questions, issues, feel free let us know.

@mciszczon
Copy link
Author

@feruzm Okay, I'll try to make a PR next week, thanks for the feedback!

muhammadahmad57 added a commit that referenced this issue Dec 3, 2021
feruzm added a commit that referenced this issue Dec 9, 2021
@feruzm feruzm closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants