Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show top curator name under the word count in the entry #1305

Merged
merged 7 commits into from
Apr 18, 2023

Conversation

MTSaeed
Copy link
Collaborator

@MTSaeed MTSaeed commented Apr 11, 2023

What does this PR?
Shows the name of top curator under the word Count in the entry page.

Steps to reproduce
1- Open any entry and you will see the name of the top curator under the word count.

Issue number

fixes #1301

Screenshot / Video

top-curator.mp4

@MTSaeed
Copy link
Collaborator Author

MTSaeed commented Apr 11, 2023

image

@feruzm
Copy link
Member

feruzm commented Apr 12, 2023

@MTSaeed Looks good, could we change username text to user avatar without name? Just avatar, like Top curator: O avatar circle and on hover native tooltip can show username. And we don't have to open on new tab, we can let people use browser feature to open on new tab if they wish to. What do you think?

@MTSaeed
Copy link
Collaborator Author

MTSaeed commented Apr 13, 2023

@MTSaeed Looks good, could we change username text to user avatar without name? Just avatar, like Top curator: O avatar circle and on hover native tooltip can show username. And we don't have to open on new tab, we can let people use browser feature to open on new tab if they wish to. What do you think?

@feruzm Updated.

curator-feedback.mp4

@MTSaeed
Copy link
Collaborator Author

MTSaeed commented Apr 18, 2023

@feruzm Updated.

@feruzm
Copy link
Member

feruzm commented Apr 18, 2023

@MTSaeed does prop already include active votes so we don’t have to do unnecessary api call to get that again?

@MTSaeed
Copy link
Collaborator Author

MTSaeed commented Apr 18, 2023

@MTSaeed does prop already include active votes so we don’t have to do unnecessary api call to get that again?
@feruzm
No, props does not include active votes. That's why we have to send API call to get votes. If we try to get active_votes from the entry object, it will just give the record of rshares and the name of the voter.

@feruzm
Copy link
Member

feruzm commented Apr 18, 2023

@MTSaeed so we can still use that, highest rshares basically is top curator.

Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit af3ba2f into development Apr 18, 2023
@feruzm feruzm deleted the top-curator branch April 18, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top curator indicator
2 participants