Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the prisma .env template was missing a colon between the username and password for the postgres url #134

Merged
merged 3 commits into from
Apr 26, 2021

Conversation

Jeremy-Doucet
Copy link
Contributor

Description of PR that completes issue here...

Changes

When I ran npx create-bison-app MyApp on my local machine, I initialized the database with:
username: postgres
password: docker

But when I ran yarn db:setup I got the following error.

❯ yarn db:setup
yarn run v1.22.10
$ yarn db:migrate && yarn prisma generate
$ yarn -s prisma migrate up --experimental && yarn build:prisma
Environment variables loaded from prisma/.env
Prisma Schema loaded from prisma/schema.prisma
Error: P1000: Authentication failed against database server at `localhost`, the provided database credentials for `postgresdocker` are not valid.

Please make sure to provide valid database credentials for the database server at `localhost`.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

It looks like there is just a small colon missing from the template.

Screenshots

(prefer animated gif)

Checklist

  • Requires dependency update?
  • Generating a new app works

Fixes #xxx

@Jeremy-Doucet
Copy link
Contributor Author

https://www.postgresql.org/docs/9.4/libpq-connect.html#LIBPQ-CONNSTRING Actually, it looks like the previous version was correct if a password was not included, and only broke if a password was included.

Copy link
Contributor

@code-jenn-or code-jenn-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great documentation of the issue and the fix!

@code-jenn-or code-jenn-or merged commit 71456f1 into canary Apr 26, 2021
@code-jenn-or code-jenn-or deleted the jdoucet/missing-psql-colon branch April 26, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants