Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Improve style of user popup #25

Closed
feisley opened this issue Apr 10, 2014 · 2 comments
Closed

Improve style of user popup #25

feisley opened this issue Apr 10, 2014 · 2 comments
Assignees
Milestone

Comments

@feisley
Copy link
Contributor

feisley commented Apr 10, 2014

As mentioned in #18 the changes made to allow configuration of the user popup doesn't look as clean as the original Confluence implementation.

Two suggestions:

  1. Remove the line break and wrap the fields around the profile image to avoid the large block of white space
  2. Remove the field titles as this is a small popup badge and the information presented within it should be obvious without labels (i.e. Name, Email, Phone, Title)
@blaubaer blaubaer self-assigned this Apr 10, 2014
@feisley
Copy link
Contributor Author

feisley commented Apr 11, 2014

Quick update: In what appears to be a random case of caching, the popups suddenly changed to wrap around the profile picture and the labels are now more subtle.

Probably just something caught in the cache on upgrade.

I do still think we should consider dropping the label from the popup as it does widen it a bit, but otherwise it looks much better already :)

@blaubaer blaubaer added this to the 0.2.0 milestone Apr 14, 2014
blaubaer added a commit that referenced this issue Apr 14, 2014
@blaubaer
Copy link
Member

I combined this with the changes of #20. It is now combined with the possiblity to define presents views in the configuration and select them also for the hovers. By using <configuration ... hoverView="<viewId>" ...> and fix the whole style back to more confluence 5 normal style. This style could now also be selected in the marco.

@blaubaer blaubaer modified the milestones: 0.1.7, 0.2.0 Jun 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants