Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo.py: erroneous calculation of "missing" files? #25

Closed
varsakelis opened this issue Mar 25, 2021 · 1 comment · Fixed by #28
Closed

Echo.py: erroneous calculation of "missing" files? #25

varsakelis opened this issue Mar 25, 2021 · 1 comment · Fixed by #28

Comments

@varsakelis
Copy link

echo.py line 112: missing = set(self.fnames) - set(os.listdir(self.root / "Videos"))

The set(self.fnames) gives the set of filenames without their extensions.
Subtracting set(os.listdir(self.root / "Videos")) (which does include extensions) leads to all filenames being considered "missing".

This then raises a FileNotFoundError, line 117.

wondering if anyone else has encountered this...

@gdims
Copy link

gdims commented Mar 31, 2021

I have also faced a conflict regarding the filenames and extensions. What I ended up doing is, I removed the ".avi" extension from all filenames, and then I modified echo.py in the:

with open(self.root / "VolumeTracings.csv") as f:

by adding

filename = os.path.splitext(filename)[0]

So that the extension is also removed there, as VolumeTracings.csv has extensions in the filenames, in contrast to FIleList.csv.

There can be other workarounds.

bryanhe added a commit to bryanhe/dynamic that referenced this issue Apr 19, 2021
byebrid pushed a commit to DeepNeuron-AI/dynamic that referenced this issue May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants