-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support to set timeout for TAXII requests #41
Conversation
cabby/abstract.py
Outdated
@@ -161,6 +162,7 @@ def _execute_request(self, request, uri=None, service_type=None): | |||
services by ``service_type``. | |||
''' | |||
|
|||
timeout = self.timeout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to have a separate local variable
cabby/abstract.py
Outdated
@@ -47,6 +47,7 @@ def __init__(self, host=None, discovery_path=None, port=None, | |||
|
|||
self.jwt_token = None | |||
self.headers = headers or {} | |||
self.timeout = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add this to constructor arguments
thank you for the pull request! Timeout is something that should've been added long time ago. Before I merge it, please adjust your code a bit:
|
also, please sync your branch with master. I removed |
Ok, will fix the issues. |
Fixing #40
This change is