Create client from URL #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, 2.7, that's your last days. |
traut
reviewed
Oct 8, 2019
cabby/__init__.py
Outdated
| @@ -20,13 +21,24 @@ def create_client(host=None, port=None, discovery_path=None, use_https=False, | |||
| :param int port: TAXII server port | |||
| :param str discovery_path: Discovery Service relative path | |||
| :param bool use_https: if HTTPS should be used | |||
| :param string url: URL to infer host, port, discovery_path, and use_https | |||
There was a problem hiding this comment.
if you're infering discovery path from it, maybe it's better to call it discovery_url instead of generic url?
There was a problem hiding this comment.
Good point. Fixed 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing
urlintocreate_clientto fill in other params from it. It could be helpful for easier application configuration through env vars, for example. See dj-database-url for more info about the motivation.Close #13