-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimeStamp to TimeStampTree #328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge with remote branch aasx-server/main
Merge with remote branch
Merge with main
Merge idta main
Merge pxc dev-sme
Comment on lines
+380
to
+382
(sme.TValue == string.Empty || sme.TValue == null) && | ||
(!withSME || (sme.SemanticId != null && sme.SemanticId.Equals(semanticId))) && | ||
(!withDiff || sme.TimeStampTree.CompareTo(diff) > 0)) |
Check notice
Code scanning / CodeQL
Complex condition Note
Complex condition: too many logical operations in this expression.
@@ -326,7 +326,7 @@ | |||
{ | |||
smId = identifier, | |||
url = $"{ExternalBlazor}/submodels/{Base64UrlEncoder.Encode(identifier)}", | |||
timeStamp = TimeStamp.TimeStamp.DateTimeToString(sm.TimeStamp) | |||
timeStampTree = TimeStamp.TimeStamp.DateTimeToString(sm.TimeStampTree) |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
Variable may be null at this access as suggested by null check.
sm
Error loading related location
Loading this
Error loading related location
Loading
Freezor
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change from using the TimeStamp to TimeStampTree in PageRetriever and Query.
Please delete options that are not relevant.
Checklist: