Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename OrtIssue to Issue #597

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

mnonnenmacher
Copy link
Contributor

Align with the renaming in ORT, see the commit messages for details.

The name refers to the ORT class which was renamed in [1].

[1]: oss-review-toolkit/ort#6415

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.com>
Rename `OrtIssuesTable` to `IssuesTable` to align with the renaming in
the previous commit. Also rename all related tables and columns.

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.com>
Use the existing functions to map from database classes to model classes
and from model classes to ORT classes instead of duplicating them.

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.com>
Copy link
Contributor

@oheger-bosch oheger-bosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This change breaks our config validation script. Also, the update on the production system should probably be done during a maintenance window since the renaming of database structures is likely to break ORT runs in progress.

@mnonnenmacher mnonnenmacher added this pull request to the merge queue Jul 4, 2024
Merged via the queue into eclipse-apoapsis:main with commit d0113d9 Jul 4, 2024
12 checks passed
@mnonnenmacher mnonnenmacher deleted the rename-ort-issue branch July 4, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants