Initial version of FS internet radio binding. #429

paphko · 2015-08-27T09:28:07Z

This binding is based on openhab 1.x binding frontiersiliconradio and is
migrated to the new ESH API, including device discovery.

kaikreuzer · 2015-08-27T20:17:32Z

Thanks! I'll do the review in September and come back to you!

kaikreuzer · 2015-10-09T17:47:54Z

extensions/binding/org.eclipse.smarthome.binding.fsinternetradio/ESH-INF/thing/thing-types.xml

+
+        <config-description>
+            <parameter name="ip" type="text" required="true">
+                <label>Internet Radio Address</label>


Remove the "Internet Radio" from all labels (config as well as channels), please - labels should be as short as possible.

paphko · 2015-11-26T09:19:33Z

@teichsta Thanks for testing :-)
@kaikreuzer I did all the changes, except for switching to another HTTP client - that would take too much time at the moment...

paphko · 2015-11-26T14:06:41Z

To be more precise: I will not change the HTTP client within the next days or even weeks, so I would suggest to finish this pull request and to open a new issue for switching to another HTTP client?

kaikreuzer · 2015-11-27T11:35:22Z

I would suggest to finish this pull request and to open a new issue for switching to another HTTP client?

Ok, I am fine with that. Would be great if you could find the time in the next months to work on the http client replacement though.
Regarding finishing this PR: I would really appreciate, if you would reconsider #429 (comment) and change this part of the code accordingly.

maggu2810 · 2015-12-01T06:38:22Z

FYI: The ESH transport bundle upnp imports packages of jupnp. The jupnp bundle itself imports a lot of the org.apache.http.* packages. So, we can get rid off it in the ESH bundles, but as long as jupnp using it, we cannot really get rid off (using e.g. the hue bundle will add it to the dependency chain).

kaikreuzer · 2015-12-02T15:34:05Z

@maggu2810, the discussion here is about Apache Commons HTTP which is yet another lib than org.apache.http, so this does not make a difference here.
Still, pointing to jUPnP is a very valid remark, which you might want to directly make at https://www.eclipse.org/forums/index.php/t/1069192/.

This binding is based on openhab 1.x binding frontiersiliconradio and is migrated to the new ESH API, including device discovery. Bug: eclipse-archived#429 Signed-off-by: Patrick Koenemann <patrick.koenemann@itemis.de> Also-by: Rainer Ostendorf <github@linlab.de>

paphko · 2015-12-08T15:23:48Z

@kaikreuzer, there are now two volume items, one is the absolute 0..32 number item, the other is a percent item. I further created a new issue about the http client that is used in this binding: #682

kaikreuzer · 2015-12-08T16:18:33Z

extensions/binding/org.eclipse.smarthome.binding.fsinternetradio/ESH-INF/thing/thing-types.xml

+        <label>Preset</label>
+        <description>Preset radio stations configured in the radio.</description>
+    </channel-type>
+    <channel-type id="volume-absolute">


Could you define this channel type as "advanced=true"?

This binding is based on openhab 1.x binding frontiersiliconradio and is migrated to the new ESH API, including device discovery. Bug: eclipse-archived#429 Signed-off-by: Patrick Koenemann <patrick.koenemann@itemis.de> Also-by: Rainer Ostendorf <github@linlab.de>

kaikreuzer · 2015-12-11T10:59:53Z

Thanks a lot for the updates, @paphko.
I actually just did a functional test and since I do not have such a radio at hand, I only tried an error situation by manually creating a Thing and pointed it to the IP address of my Fritz!Box - we will need some improvements on the logging here :-)

kaikreuzer · 2015-12-11T11:02:17Z

.../eclipse/smarthome/binding/fsinternetradio/internal/radio/FrontierSiliconRadioApiResult.java

+        try {
+            xml = getXmlDocFromString(requestResultString);
+        } catch (Exception e) {
+            logger.error("converting to XML failed: '" + requestResultString + "' with " + e.getClass().getName() + ": "


this should only be debugging or trace level - and the message prints out the full XML, which is potentially huge. So you might log the e.getMessage() as debug, but the requestResultString should definitely only be trace level.

This binding is based on openhab 1.x binding frontiersiliconradio and is migrated to the new ESH API, including device discovery. Bug: eclipse-archived#429 Signed-off-by: Patrick Koenemann <patrick.koenemann@itemis.de> Also-by: Rainer Ostendorf <github@linlab.de>

paphko · 2015-12-23T11:40:31Z

@kaikreuzer Done.

kaikreuzer · 2015-12-23T23:17:15Z

Thanks!
As the code is > 1000 lines, I have created CQ 10558 and am now waiting for approval from the IP team before we can merge this PR.

kaikreuzer · 2016-01-08T11:47:54Z

CQ has been approved for parallel IP checkin!

paphko force-pushed the fsinternetradio-binding branch 4 times, most recently from 48235cf to 289b481 Compare August 27, 2015 11:16

kaikreuzer added the enhancement label Aug 27, 2015

kaikreuzer self-assigned this Aug 27, 2015

kaikreuzer reviewed Oct 9, 2015
View reviewed changes

paphko mentioned this pull request Dec 2, 2015

Frontiersiliconradio binding for internet radios based on frontier silicon chipset openhab/openhab1-addons#2576

Merged

paphko force-pushed the fsinternetradio-binding branch from 641df39 to dec35b8 Compare December 8, 2015 15:17

paphko mentioned this pull request Dec 8, 2015

FS internet radio binding: Replace apache http client with jetty http client #682

Closed

kaikreuzer reviewed Dec 8, 2015
View reviewed changes

paphko force-pushed the fsinternetradio-binding branch from dec35b8 to 4ad454d Compare December 8, 2015 16:43

paphko force-pushed the fsinternetradio-binding branch from 4ad454d to 48da1fe Compare December 8, 2015 16:45

kaikreuzer reviewed Dec 11, 2015
View reviewed changes

paphko force-pushed the fsinternetradio-binding branch from 48da1fe to e16ab74 Compare December 23, 2015 11:39

kaikreuzer added CQ and removed feedback labels Dec 23, 2015

kaikreuzer merged commit e16ab74 into eclipse-archived:master Jan 8, 2016

kaikreuzer removed the CQ label Jan 8, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial version of FS internet radio binding. #429

Initial version of FS internet radio binding. #429

paphko commented Aug 27, 2015

kaikreuzer commented Aug 27, 2015

kaikreuzer Oct 9, 2015

paphko commented Nov 26, 2015

paphko commented Nov 26, 2015

kaikreuzer commented Nov 27, 2015

maggu2810 commented Dec 1, 2015

kaikreuzer commented Dec 2, 2015

paphko commented Dec 8, 2015

kaikreuzer Dec 8, 2015

paphko Dec 8, 2015

kaikreuzer commented Dec 11, 2015

kaikreuzer Dec 11, 2015

paphko commented Dec 23, 2015

kaikreuzer commented Dec 23, 2015

kaikreuzer commented Jan 8, 2016

Initial version of FS internet radio binding. #429

Initial version of FS internet radio binding. #429

Conversation

paphko commented Aug 27, 2015

kaikreuzer commented Aug 27, 2015

kaikreuzer Oct 9, 2015

Choose a reason for hiding this comment

paphko commented Nov 26, 2015

paphko commented Nov 26, 2015

kaikreuzer commented Nov 27, 2015

maggu2810 commented Dec 1, 2015

kaikreuzer commented Dec 2, 2015

paphko commented Dec 8, 2015

kaikreuzer Dec 8, 2015

Choose a reason for hiding this comment

paphko Dec 8, 2015

Choose a reason for hiding this comment

kaikreuzer commented Dec 11, 2015

kaikreuzer Dec 11, 2015

Choose a reason for hiding this comment

paphko commented Dec 23, 2015

kaikreuzer commented Dec 23, 2015

kaikreuzer commented Jan 8, 2016