This repository has been archived by the owner on May 7, 2020. It is now read-only.
Deprecate & deactivate DiscoveryServiceCallback and ExtendedDiscovery… #6237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should discuss further having feedback to allow the discovery handler in the binding to know which things have already been added to inbox or as things. This removal is not nice - as discussed earlier!
…Sent from my iPhone
On 19 Sep 2018, at 11:57, Henning Treu ***@***.***> wrote:
…Service
Fixes #6216.
Signed-off-by: Henning Treu ***@***.***
You can view, comment on, or merge this pull request online at:
#6237
Commit Summary
Deprecate & deactivate DiscoveryServiceCallback and ExtendedDiscoverySerice
File Changes
M bundles/config/org.eclipse.smarthome.config.discovery.test/src/test/java/org/eclipse/smarthome/config/discovery/DiscoveryServiceRegistryOSGiTest.java (92)
D bundles/config/org.eclipse.smarthome.config.discovery.test/src/test/java/org/eclipse/smarthome/config/setup/test/discovery/ExtendedDiscoveryServiceMock.java (59)
M bundles/config/org.eclipse.smarthome.config.discovery/src/main/java/org/eclipse/smarthome/config/discovery/DiscoveryServiceCallback.java (28)
M bundles/config/org.eclipse.smarthome.config.discovery/src/main/java/org/eclipse/smarthome/config/discovery/ExtendedDiscoveryService.java (5)
M bundles/config/org.eclipse.smarthome.config.discovery/src/main/java/org/eclipse/smarthome/config/discovery/internal/DiscoveryServiceRegistryImpl.java (63)
Patch Links:
https://github.com/eclipse/smarthome/pull/6237.patch
https://github.com/eclipse/smarthome/pull/6237.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
And this should be tagged as API breaking ? |
kaikreuzer
suggested changes
Sep 24, 2018
| @@ -24,25 +23,30 @@ | |||
| * <p> | |||
| * This interface must not be implemented by bindings. | |||
| * | |||
| * @deprecated The use of this callback is deprecated. The {@link Inbox} should be able to deal with updates. | |||
| * Incremental discovery should be handled internaly by each {@link DiscoveryService}. | |||
| @@ -24,25 +23,30 @@ | |||
| * <p> | |||
| * This interface must not be implemented by bindings. | |||
| * | |||
| * @deprecated The use of this callback is deprecated. The {@link Inbox} should be able to deal with updates. | |||
There was a problem hiding this comment.
"should be able" -> "is able"
There was a problem hiding this comment.
I was thinking about a custom Inbox implementation. But you a re right, ESH offers this behaviour. Will change.
There was a problem hiding this comment.
If you want to address any implementation, you can also say "must be able".
| @@ -21,9 +21,14 @@ | |||
| * The {@link DiscoveryService} will get a {@link DiscoveryServiceCallback}, which provides the extended framework | |||
| * capabilities. | |||
| * | |||
| * @deprecated The extended access to the core framework was misused most of the time and will be removed in a later | |||
There was a problem hiding this comment.
I think the main reason for deprecation is the cyclic dependency. You should not make our consumers feel guilty about it.
There was a problem hiding this comment.
yes, you a re right. I re-wrote this sentence 3 times. will change.
…Serice Fixes eclipse-archived#6216. Signed-off-by: Henning Treu <henning.treu@telekom.de>
htreu
force-pushed
the
6216_deprecate_ex_discovery_service
branch
from
7d3df0b
to
5d5652b
Compare
Signed-off-by: Henning Treu <henning.treu@telekom.de>
added 2 commits
September 27, 2018 11:09
Signed-off-by: Henning Treu <henning.treu@telekom.de>
Signed-off-by: Henning Treu <henning.treu@telekom.de>
kaikreuzer
approved these changes
Sep 27, 2018
This was referenced Oct 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Service
Fixes #6216.
Signed-off-by: Henning Treu henning.treu@telekom.de