Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClassCastException while emitting "postscript" format #1010 #1015

Merged
merged 1 commit into from
Jul 21, 2022
Merged

ClassCastException while emitting "postscript" format #1010 #1015

merged 1 commit into from
Jul 21, 2022

Conversation

claesrosell
Copy link
Contributor

During reflective access to the "trueTypeFonts" field of
"FontFactoryImpl" the type "Properties" was assumed, but the type has
changed to "HashMap" in OpenPDF. Stopped using reflective access to the
field since there are now API to access the content of "trueTypeFonts".

@claesrosell
ClassCastException while emitting "postscript" format eclipse-birt#1010
540d9d5 
During reflective access to the "trueTypeFonts" field of
"FontFactoryImpl" the type "Properties" was assumed, but the type has
changed to "HashMap" in OpenPDF. Stopped using reflective access to the
field since there are now API to access the content of "trueTypeFonts".
@claesrosell claesrosell self-assigned this Jul 21, 2022
@ruspl-afed ruspl-afed self-requested a review July 21, 2022 08:55
ruspl-afed
ruspl-afed approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hvbtup
hvbtup reviewed Jul 21, 2022
View reviewed changes
Copy link
Contributor

@hvbtup hvbtup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the change to "getFontPath":
The old code used fontName.toLowerCase() while the new code just uses fontName.

Is that intented and what's the reason?
This could perhaps cause a regression on case-sensitive file systems.

@claesrosell
Copy link
Contributor Author

Regarding the change to "getFontPath": The old code used fontName.toLowerCase() while the new code just uses fontName.

Is that intented and what's the reason? This could perhaps cause a regression on case-sensitive file systems.

The .getFontPath() method on FontFactoryImpl is doing the .toLowerCase() call.

@claesrosell claesrosell linked an issue Jul 21, 2022 that may be closed by this pull request
java.lang.ClassCastException error when running render task to "postscript" format #1010
Closed
hvbtup
hvbtup approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@hvbtup hvbtup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK then.

@claesrosell claesrosell merged commit 826bf91 into eclipse-birt:master Jul 21, 2022
@claesrosell claesrosell deleted the 1010-javalangclasscastexception-error-when-running-render-task-to-postscript-format branch July 21, 2022 11:05
@wimjongman wimjongman added this to the 4.10 milestone Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruspl-afed ruspl-afed ruspl-afed approved these changes

@hvbtup hvbtup hvbtup approved these changes

@wimjongman wimjongman Awaiting requested review from wimjongman

Assignees

@claesrosell claesrosell

Labels
None yet
Projects
None yet
Milestone
4.10
Development

Successfully merging this pull request may close these issues.

java.lang.ClassCastException error when running render task to "postscript" format
4 participants
@claesrosell @hvbtup @ruspl-afed @wimjongman