Out of memory error when creating a chart #1727 #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes NumberFormat is used to handle the decimal point and in other cases there is a dependency on ULocale. A small fix was made to use the default ULocale in the Numberformat calculations instead of the default NumberFormat The whole operation is not fully understood so more issues could arise. See the issue for a discussion.
1. Sometimes NumberFormat is used to handle the decimal point and in other cases there is a dependency on ULocale. A small fix was made to use the default ULocale in the Numberformat calculations instead of the default NumberFormat The whole operation is not fully understood so more issues could arise. 2. To avoid memory cramps, an additional 1GB was added to the maximum memory. See the issue for a discussion.
speckyspooky
approved these changes
Jun 13, 2024
merks
approved these changes
Jun 13, 2024
|
FYI, I'll kick of a milestone build after the nightly build completes. |
|
Cheers! |
|
Fun fact: While driving to work this morning, I thought that the issue might be caused by the usage of different locales at different places, which could be caused by using different libraries (or by different versions of the same library, not all initialized in the same way, "thanks" to OSGI). Looking at Wim's fix, it seems that I was on the right track. I'd bet that the issues I experienced on a German Windows eg. when I try to specify a border width of 0.5 pt (because "small" border width is still not small enough) have similar reasons. |
|
Hi Henning, yes, you were on the right track. Now we know better the underlying issue we can probably also fix these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and in other cases there is a dependency on ULocale.
A small fix was made to use the default ULocale in the
Numberformat calculations instead of the default NumberFormat
The whole operation is not fully understood so more issues
could arise.
maximum memory.
See the issue for a discussion.