Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move license to EPL 2 #683 #807

Merged
merged 8 commits into from
Feb 7, 2022

Conversation

SteveSchafer-Innovent
Copy link
Contributor

Change all occurrences of Eclipse Public License version 1 to version 2
in the entire repository. 12391 files changed! Time to get some other
eyeballs on this.

Signed-off-by: Steve Schafer sschafer@innoventsolutions.com

Change all occurrences of Eclipse Public License version 1 to version 2
in the entire repository.  12391 files changed!  Time to get some other
eyeballs on this.

Signed-off-by: Steve Schafer <sschafer@innoventsolutions.com>
@SteveSchafer-Innovent
Copy link
Contributor Author

It appears I can't put copyright notices in the test xml files.

@wimjongman
Copy link
Contributor

I think there is a set of "golden" xmls that is compared with output during the test. They should not be changed.

@wimjongman
Copy link
Contributor

How are you doing Steve? Maybe the all-in-one is a bite too big? Do you need help?

@SteveSchafer-Innovent
Copy link
Contributor Author

It's just a matter of working through the issues turned up in testing. I'm trying to keep manual changes to a minimum so I'm tweaking the regular expressions to account for all variations, e.g. having the entire XML on one line, which was the last thing I ran into. It looks like I'm getting close to a successful build. I'd be surprised if I'm not done today or early next week.

@SteveSchafer-Innovent
Copy link
Contributor Author

And as it turns out, the next build worked!

@wimjongman
Copy link
Contributor

Well done, Steve! Please Squash and merge when you are done. Thank you for your work.

@SteveSchafer-Innovent
Copy link
Contributor Author

Being a newly minted committer, I've never merged before. I don't know what "Squash" means. Is there anything else I should know?

@wimjongman wimjongman merged commit c317951 into eclipse-birt:master Feb 7, 2022
@wimjongman
Copy link
Contributor

Squash merge means that all commits from the branch are squashed into one when merging into master. This keeps the master history clean. I have done the merge and recorded this in a video. Please find it attached.

squash.mp4

@SteveSchafer-Innovent
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants