Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heath check uses hardcoded URL #6

Closed
bhufmann opened this issue Jun 23, 2023 · 0 comments · Fixed by #7
Closed

Heath check uses hardcoded URL #6

bhufmann opened this issue Jun 23, 2023 · 0 comments · Fixed by #7
Labels
bug Something isn't working

Comments

@bhufmann
Copy link
Contributor

bhufmann commented Jun 23, 2023 •
edited
Loading

When the extension doing a heath check (HTTP query) to the server to check if the server is available it uses hard-coded URL http://localhost:8080. Since it's possible to change the port on the server, the client site needs to be configurable as well.

When using this extension with vscode-trace-extension, use the URL from that extension.
@bhufmann bhufmann added the bug Something isn't working label Jun 23, 2023
@bhufmann bhufmann changed the title Heath check uses hardcoded port Heath check uses hardcoded URL Jun 23, 2023
bhufmann added a commit to bhufmann/vscode-trace-server that referenced this issue Jun 23, 2023
@bhufmann
Get server URL from the client preferences (vscode-trace-extension)
0e05f32 
This allows to change the URL when running the vscode-trace-server
extension in conjunction with the vscode-trace-extension.

fixes eclipse-cdt-cloud#6

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
@bhufmann bhufmann mentioned this issue Jun 23, 2023
Merged
bhufmann added a commit that referenced this issue Jun 27, 2023
@bhufmann
Get server URL from the client preferences (vscode-trace-extension)
794d1fe 
This allows to change the URL when running the vscode-trace-server
extension in conjunction with the vscode-trace-extension.

fixes #6

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get server URL from the client preferences (vscode-trace-extension) bhufmann/vscode-trace-server
1 participant
@bhufmann