Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions changed to Maven 3.9.0 which breaks the build #308

Closed
jonahgraham opened this issue Mar 6, 2023 · 3 comments · Fixed by #309
Closed

GitHub Actions changed to Maven 3.9.0 which breaks the build #308

jonahgraham opened this issue Mar 6, 2023 · 3 comments · Fixed by #309
Labels
releng Release engineering and project management

Comments

@jonahgraham
Copy link
Member

We get exceptions such as

Error: [ERROR] Internal error: java.lang.NullPointerException: Cannot invoke "org.apache.maven.repository.internal.ModelCacheFactory.createCache(org.eclipse.aether.RepositorySystemSession)" because "this.modelCacheFactory" is null -> [Help 1]
org.apache.maven.InternalErrorException: Internal error: java.lang.NullPointerException: Cannot invoke "org.apache.maven.repository.internal.ModelCacheFactory.createCache(org.eclipse.aether.RepositorySystemSession)" because "this.modelCacheFactory" is null

I expect upgrading to newest Tycho is the solution, which means going from 2.x to 3.x version of Tycho.
@jonahgraham jonahgraham added the releng Release engineering and project management label Mar 6, 2023
@jonahgraham jonahgraham mentioned this issue Mar 6, 2023
Merged
@jonahgraham
Copy link
Member Author

See full example of a broken build in https://github.com/eclipse-cdt/cdt/actions/runs/4338425286/jobs/7593869516

@akurtakov
Copy link
Contributor

You need Tycho 3.0.3 as a minimum for Maven 3.9.0.

@jonahgraham
Copy link
Member Author

Thanks @akurtakov for confirmation. I'll be doing the upgrade soonish.

jonahgraham referenced this issue in eclipse-cdt/cdt-lsp Mar 7, 2023
@ghentschke
Update tycho-build.yaml
f776179
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Mar 7, 2023
@jonahgraham
Fix maven at 3.8.7
03fe16d 
Until we update Tycho to 3.0.3+ we use the older Maven

Thanks to @ghentschke for figuring this out in
eclipse-cdt/cdt-lsp@f776179

Fixes eclipse-cdt#308
@jonahgraham jonahgraham mentioned this issue Mar 7, 2023
Merged
jonahgraham added a commit that referenced this issue Mar 7, 2023
@jonahgraham
Fix maven at 3.8.7
6776f6a 
Until we update Tycho to 3.0.3+ we use the older Maven

Thanks to @ghentschke for figuring this out in
eclipse-cdt/cdt-lsp@f776179

Fixes #308
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Mar 13, 2023
@jonahgraham
Upgrade to Tycho 3.0.3 (latest)
3cb82a3 
Part of eclipse-cdt#320
See also eclipse-cdt#308
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Mar 14, 2023
@jonahgraham
Upgrade to Tycho 3.0.3 (latest)
5abaa7c 
Part of eclipse-cdt#320
See also eclipse-cdt#308
@jonahgraham jonahgraham mentioned this issue Mar 14, 2023
Merged
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Mar 14, 2023
@jonahgraham
Bump bundle versions changed due to new Tycho
3bdf1cb 
When we update Tycho we pull in a new version of ECJ which means
we can get some differences in the class files even though
there is no difference in the source. This commit bumps
all the bundles that are affected by this.

This is kept as a separate commit from the Tycho update
because if we need to revert the Tycho update we would still
need to bump all these bundles to make jgit timestamp qualifier
happy.

Part of eclipse-cdt#320
See also eclipse-cdt#308
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Mar 14, 2023
@jonahgraham
Bump bundle versions changed due to new Tycho
8940a9b 
When we update Tycho we pull in a new version of ECJ which means
we can get some differences in the class files even though
there is no difference in the source. This commit bumps
all the bundles that are affected by this.

This is kept as a separate commit from the Tycho update
because if we need to revert the Tycho update we would still
need to bump all these bundles to make jgit timestamp qualifier
happy.

Part of eclipse-cdt#320
See also eclipse-cdt#308
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Mar 14, 2023
@jonahgraham
Upgrade to Tycho 3.0.3 (latest)
c18d06e 
Part of eclipse-cdt#320
See also eclipse-cdt#308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
releng Release engineering and project management
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix maven at 3.8.7 jonahgraham/cdt
2 participants
@akurtakov @jonahgraham