Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDT 11.3 does not have BREE header in MANIFEST.MF, uses Require-Capability, causes false positive API Compatibility errors #551

Closed
jonahgraham opened this issue Sep 14, 2023 · 7 comments · Fixed by #554
Closed

CDT 11.3 does not have BREE header in MANIFEST.MF, uses Require-Capability, causes false positive API Compatibility errors #551

jonahgraham opened this issue Sep 14, 2023 · 7 comments · Fixed by #554

Comments

@jonahgraham
Copy link
Member

Perhaps as a result of updating Tycho upgrade the CDT 11.3 manifests publish with:

Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=17))"

automatically converted from BREE:

Bundle-RequiredExecutionEnvironment: JavaSE-17

This leads to false positive API errors like this:

2023-09-13T22:28:04.9985777Z [API ERROR] File MANIFEST.MF at line 5: The minor version should be incremented in version 8.3.0, since execution environments have been changed since version 8.3.0 (location: /home/runner/work/cdt/cdt/core/org.eclipse.cdt.core/META-INF/MANIFEST.MF)
This was referenced Sep 14, 2023
Merged
Merged
@jonahgraham
Copy link
Member Author

I suspect the easiest thing short term is to add API filters for this error, but I need to track this back to Tycho and/or PDE to resolve fully.

@akurtakov
Copy link
Contributor

This is PDE issue for sure as BREE is deprecated by OSGi for years although PDE never made the move.

@Kummallinen
Copy link
Contributor

Kummallinen commented Sep 14, 2023 •
edited
Loading

I'm using Tycho 4.0.1 to build our IDE and we still have Bundle-RequiredExecutionEnvironment headers in manifests of the built jar files

@Kummallinen
Copy link
Contributor

Kummallinen commented Sep 14, 2023 •
edited
Loading

@jonahgraham Looking at the differences in the CDT pom & my local ones, I think the difference causing this is I have "<deriveHeaderFromSource>false</deriveHeaderFromSource>" in the tycho-packaging-plugin configuration. See https://github.com/eclipse-tycho/tycho/blob/master/RELEASE_NOTES.md#new-parameter-in-tycho-packaging-pluginpackage-plugin

jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 14, 2023
@jonahgraham
Restore BREE headers to all MANIFEST.MF
6c19fec 
Fixes eclipse-cdt#551
@jonahgraham jonahgraham mentioned this issue Sep 14, 2023
Merged
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 14, 2023
@jonahgraham
Restore BREE headers to all MANIFEST.MF
bf2e0a5 
Fixes eclipse-cdt#551
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 14, 2023
@jonahgraham
Workaround for API error of missing BREE in CDT 11.3.0
e07d072 
Workaround for eclipse-cdt#551
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 14, 2023
@jonahgraham
Workaround for API error of missing BREE in CDT 11.3.0
9a5a30e 
Workaround for eclipse-cdt#551
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 14, 2023
@jonahgraham
Workaround for API error of missing BREE in CDT 11.3.0
2bc7725 
Workaround for eclipse-cdt#551
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 14, 2023
@jonahgraham
Service segment bumps for CDT 11.4.0 and BREE problem
50c5ee0 
With BREE back on in eclipse-cdt#551 we bump all affected bundles so make
sure we republish updated versions in 11.4

Part of eclipse-cdt#548
Part of eclipse-cdt#551
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 14, 2023
@jonahgraham
Restore BREE headers to all MANIFEST.MF
40b2226 
Includes adding API error filters for the places
where PDE does not detect Require-Capability in
place of BREE.

With BREE back on we bump all affected bundles so make
sure we republish updated versions in 11.4

Fixes eclipse-cdt#551
@jonahgraham jonahgraham mentioned this issue Sep 14, 2023
Merged
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 15, 2023
@jonahgraham
Restore BREE headers to all MANIFEST.MF
b6c9249 
Includes adding API error filters for the places
where PDE does not detect Require-Capability in
place of BREE.

With BREE back on we bump all affected bundles so make
sure we republish updated versions in 11.4

Fixes eclipse-cdt#551
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 15, 2023
@jonahgraham
Disable API Baseline checks in builds
55ea598 
To workaround eclipse-cdt#551 we need to make a CDT 11.3.1 build that
has the BREE restored to use as a baseline for CDT 11.3.2
(if we release that) and CDT 11.4.0
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 15, 2023
@jonahgraham
Prepare repo for CDT 11.3.1
94a8400 
Part of eclipse-cdt#551
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 15, 2023
@jonahgraham
Bump all bundles that are missing BREE in 11.3.0
f60f5b6 
Part of eclipse-cdt#551
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 15, 2023
@jonahgraham
Bump all bundles that are missing BREE in 11.3.0
a92b90a 
Part of eclipse-cdt#551
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 15, 2023
@jonahgraham
Use temporary baseline of unreleased CDT 11.3.1
65c3ddd 
This is to workaround the missing BREE in CDT 11.3.0, see
eclipse-cdt#551 for details

Part of eclipse-cdt#551
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 15, 2023
@jonahgraham
Use temporary baseline of unreleased CDT 11.3.1
49a7a34 
This is to workaround the missing BREE in CDT 11.3.0, see
eclipse-cdt#551 for details

Part of eclipse-cdt#551
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 15, 2023
@jonahgraham
Fix multiple repositories in API baseline
92beadb 
This happened to work before because the contents of
api-baseline.repo was in api-baseline.repo.simrel so
the error in the pom.xml went undetected until
eclipse-cdt#551 issue meant api-baseline.repo wasn't in
api-baseline.repo.simrel
@jonahgraham jonahgraham mentioned this issue Sep 15, 2023
Closed
@jonahgraham
Copy link
Member Author

The final resolution of this:

Last question, should we publish 11.3.1 fully (i.e. add it to https://download.eclipse.org/tools/cdt/releases/11.3/ composite) or just add a note as to why it is excluded. My current preference is the latter, but I am open to suggestions!

@jonahgraham jonahgraham reopened this Sep 15, 2023
@Kummallinen
Copy link
Contributor

I'd vote for not publishing 11.3.1 and just adding a note. Future updates will still work so there doesn't seem to be any need to cause an extra update for users.

@jonahgraham
Copy link
Member Author

Done in 78e1520 and https://ci.eclipse.org/cdt/job/promote-files-to-download/ has been run to copy the files to https://download.eclipse.org/tools/cdt/releases/11.3/

@jonahgraham jonahgraham mentioned this issue Sep 15, 2023
Merged
davmac314 pushed a commit to davmac314/cdt that referenced this issue Sep 24, 2023
@jonahgraham @davmac314
Restore BREE headers to all MANIFEST.MF
bfdf56c 
Fixes eclipse-cdt#551
davmac314 pushed a commit to davmac314/cdt that referenced this issue Sep 24, 2023
@jonahgraham @davmac314
Bump all bundles that are missing BREE in 11.3.0
9a6b761 
Part of eclipse-cdt#551
davmac314 pushed a commit to davmac314/cdt that referenced this issue Sep 24, 2023
@jonahgraham @davmac314
Use temporary baseline of unreleased CDT 11.3.1
b0cc2fd 
This is to workaround the missing BREE in CDT 11.3.0, see
eclipse-cdt#551 for details

Part of eclipse-cdt#551
davmac314 pushed a commit to davmac314/cdt that referenced this issue Sep 24, 2023
@jonahgraham @davmac314
Fix multiple repositories in API baseline
4173c32 
This happened to work before because the contents of
api-baseline.repo was in api-baseline.repo.simrel so
the error in the pom.xml went undetected until
eclipse-cdt#551 issue meant api-baseline.repo wasn't in
api-baseline.repo.simrel
davmac314 pushed a commit to davmac314/cdt that referenced this issue Sep 24, 2023
@jonahgraham @davmac314
Make note in download.eclipse.org why CDT 11.3.1 isn't in composites
fa675c4 
Fixes eclipse-cdt#551
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Sep 25, 2023
@jonahgraham
Synchronize cdt.setup's API baseline with cdt-baseline.target
0d85f6c 
Part of eclipse-cdt#551
@jonahgraham jonahgraham mentioned this issue Sep 25, 2023
Merged
jonahgraham added a commit to jonahgraham/eclipse-cdt-lsp that referenced this issue Feb 22, 2024
@jonahgraham
Update to Tycho 4.0.6
cf43ad8 
A newer Tycho is needed to enable build and test against more
recent platform.

tycho-packaging-plugin is needed explicitly to ensure that
the headers in MANIFEST.MF are not removed during build. This
ensures cdt-lsp doesn't have this same problem as CDT had recently
eclipse-cdt/cdt#551

The inclusion of tycho-packaging-plugin also contains the missing
source references in the MANIFEST.MF outputs.
jonahgraham added a commit to jonahgraham/eclipse-cdt-lsp that referenced this issue Feb 22, 2024
@jonahgraham
Update to Tycho 4.0.6
d784221 
A newer Tycho is needed to enable build and test against more
recent platform.

tycho-packaging-plugin is needed explicitly to ensure that
the headers in MANIFEST.MF are not removed during build. This
ensures cdt-lsp doesn't have this same problem as CDT had recently
eclipse-cdt/cdt#551

The inclusion of tycho-packaging-plugin also contains the missing
source references in the MANIFEST.MF outputs.
jonahgraham added a commit to jonahgraham/eclipse-cdt-lsp that referenced this issue Feb 22, 2024
@jonahgraham
Update to Tycho 4.0.6
28347a0 
A newer Tycho is needed to enable build and test against more
recent platform.

tycho-packaging-plugin is needed explicitly to ensure that
the headers in MANIFEST.MF are not removed during build. This
ensures cdt-lsp doesn't have this same problem as CDT had recently
eclipse-cdt/cdt#551

The inclusion of tycho-packaging-plugin also contains the missing
source references in the MANIFEST.MF outputs.
jonahgraham added a commit to eclipse-cdt/cdt-lsp that referenced this issue Feb 22, 2024
@jonahgraham
Update to Tycho 4.0.6
90a1a52 
A newer Tycho is needed to enable build and test against more
recent platform.

tycho-packaging-plugin is needed explicitly to ensure that
the headers in MANIFEST.MF are not removed during build. This
ensures cdt-lsp doesn't have this same problem as CDT had recently
eclipse-cdt/cdt#551

The inclusion of tycho-packaging-plugin also contains the missing
source references in the MANIFEST.MF outputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prepare repo for cdt 11.4.0 development jonahgraham/cdt
3 participants
@akurtakov @jonahgraham @Kummallinen