Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#746] Use inclusive language in codan #794

Merged
merged 2 commits into from
May 22, 2024

Conversation

thomas-z8
Copy link
Contributor

Hello,

This PR is meant to be a replacement for the PR 769 which would certainly have created backward compatibility problems and would have broken users already using the checker.

This PR therefore only contains minimal changes to litterals which can be seen in the frontend interface of Eclipse.

I also bumped the service segment by 100 in the file MANIFEST.MF (thank you a lot for the additional informations about this!)

All actions could be run without errors on the forked repository in my userspace, but unfortunately I could not find a .zip artifact with a runnable Eclipse to test if my changes work as expected (for example this action run produced a .zip artifact but it seems incomplete and I did not find a runnable Eclipse in it (maybe you can provide me with additional informations about this as well ?)

Thank you and regards
Thomas

@jonahgraham
Copy link
Member

Thanks @thomas-z8 - I will be merging this lite version ASAP so that it makes it into 2024-06 release cycle.

@jonahgraham
Copy link
Member

All actions could be run without errors on the forked repository in my userspace, but unfortunately I could not find a .zip artifact with a runnable Eclipse to test if my changes work as expected (for example this action run produced a .zip artifact but it seems incomplete and I did not find a runnable Eclipse in it (maybe you can provide me with additional informations about this as well ?)

It is great you got it working in your forked repo cleanly. Once your first commit is merged in this repo, the runs in the PR will be done automatically.

The build here doesn't produce a runnable Eclipse. It produces a p2 site that can be used to install CDT into an Eclipse installation (from Help -> Install New Software).

That said, the github build does not save that p2 site anyway, perhaps a change like this would do it:

$ git diff
diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml
index d24f743427..15b12366c8 100644
--- a/.github/workflows/build-test.yml
+++ b/.github/workflows/build-test.yml
@@ -64,3 +64,9 @@ jobs:
         path: |
           */*/target/surefire-reports/*.xml
           terminal/plugins/org.eclipse.tm.terminal.test/target/surefire-reports/*.xml
+    - name: Upload p2 repo
+      uses: actions/upload-artifact@v3
+      if: success() || failure()
+      with:
+        name: Eclipse CDT p2 repo
+        path: 'releng/org.eclipse.cdt.repo/target/repository'

But I personally would just build CDT locally using these instructions in building.md.

@jonahgraham jonahgraham changed the title Issue 746 lite version v2 [#746Use inclusive language May 22, 2024
@jonahgraham jonahgraham changed the title [#746Use inclusive language [#746] Use inclusive language in codan May 22, 2024
@jonahgraham jonahgraham merged commit cbcad29 into eclipse-cdt:main May 22, 2024
5 checks passed
@jonahgraham jonahgraham added this to the 11.6.0 milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants