Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM optimization remarks. #803

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

ewaterlander
Copy link
Contributor

Added support for LLVM optimization remarks to the GCC c/c++ error parser. They were falsly treated as errors (OtherError). Now they are treated as generic infos. GCC has no diagnostic messages of 'remark' type. Since GCC and LLVM messages are very similar, no separate LLVM error parser was created.

Fixes #752

Added support for LLVM optimization remarks to the GCC c/c++ error
parser. They were falsly treated as errors (OtherError). Now they are
treated as generic infos. GCC has no diagnostic messages of 'remark'
type. Since GCC and LLVM messages are very similar, no separate LLVM
error parser was created.

Fixes eclipse-cdt#752
@jonahgraham jonahgraham merged commit cd0292a into eclipse-cdt:main May 29, 2024
5 checks passed
@jonahgraham
Copy link
Member

Thanks @ewaterlander

@jonahgraham jonahgraham added this to the 11.6.0 milestone May 29, 2024
@jonahgraham jonahgraham added the build Build components of CDT, anything to do with running the compiler, using Make, CMake, or any builder label May 29, 2024
@ewaterlander ewaterlander deleted the llvm_remarks branch May 29, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build components of CDT, anything to do with running the compiler, using Make, CMake, or any builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error parser for LLVM Clang
2 participants