-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workspace status flickering on startup #1155
Conversation
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1155 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1155", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.16 :: dashboard_3.x/517: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/7352: Console, Changes, Git Data |
Build 3.16 :: push-latest-container-to-quay_3.x/4829: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7337: dashboard : 3.x :: Build 63103220 : quay.io/devspaces/dashboard-rhel8:3.16-14 |
Build 3.16 :: update-digests_3.x/7230: Console, Changes, Git Data |
Build 3.16 :: dashboard_3.x/517: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7352 triggered |
Build 3.16 :: operator-bundle_3.x/3376: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/7353: Console, Changes, Git Data |
Build 3.16 :: push-latest-container-to-quay_3.x/4830: Console, Changes, Git Data |
Build 3.16 :: copyIIBsToQuay/2735: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/7353: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7338 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.16 :: operator-bundle_3.x/3376: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7353 triggered |
Build 3.16 :: update-digests_3.x/7230: Detected new images: rebuild operator-bundle |
Build 3.16 :: dsc_3.x/1974: Console, Changes, Git Data |
Build 3.16 :: dsc_3.x/1974: 3.16.0-CI |
Build 3.16 :: copyIIBsToQuay/2735: 3.16 |
@akurinnoy: FYI: I tested PR in Dev Spaces 3.15 with Che Dashboard quay.io/eclipse/che-dashboard:pr-1155 deployed to the ROSA 4.16 cluster by creating several workspaces from "User Dashboard -> Create Workspace" page, stopped workspace in parallel when start workspace - all worked good. No unexpected status change from |
What does this PR do?
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-6287
Is it tested? How?
Status changed unexpectedly to "Stopped"
warning message while the workspace continues to start.