Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace status flickering on startup #1155

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

  • Removed the unwanted ability to overwrite a newer workspace status with an older one;
  • Workspace startup page: Fixed status glitches during a workspace start.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-6287

Is it tested? How?

  1. Deploy Che and patch the CR using the command from the github-actions bot.
  2. Create and start workspaces. There should be no Status changed unexpectedly to "Stopped" warning message while the workspace continues to start.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jul 30, 2024

Click here to review and test in web IDE: Contribute

@akurinnoy akurinnoy self-assigned this Jul 30, 2024
Copy link

openshift-ci bot commented Jul 30, 2024

@akurinnoy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-e2e-puppeteer 609c9e2 link true /test v14-e2e-puppeteer
ci/prow/v14-dashboard-happy-path 609c9e2 link true /test v14-dashboard-happy-path
ci/prow/v14-images 609c9e2 link true /test v14-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1155

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1155", name: che-dashboard}]}}]"

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit af13728 into main Aug 5, 2024
13 of 16 checks passed
@akurinnoy akurinnoy deleted the fix-stopped-workspace branch August 5, 2024 14:30
@devstudio-release
Copy link

Build 3.16 :: dashboard_3.x/517: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: dashboard_3.x/517: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7352 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: copyIIBsToQuay/2735: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: sync-to-downstream_3.x/7353: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7338 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.16 :: operator-bundle_3.x/3376: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7353 triggered

@devstudio-release
Copy link

Build 3.16 :: update-digests_3.x/7230: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/3376 triggered

@devstudio-release
Copy link

Build 3.16 :: dsc_3.x/1974: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: dsc_3.x/1974: SUCCESS

3.16.0-CI

@devstudio-release
Copy link

Build 3.16 :: copyIIBsToQuay/2735: SUCCESS

3.16
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.16-30
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:???
+ s390x-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.16-v4.16-781663- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.16-v4.16-781663- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.16-v4.16-s390x
  + <a href=https://quay.io/devspaces/iib:3.16-v4.15-781662- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.16-v4.15-781662- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.16-v4.15-s390x
  + <a href=https://quay.io/devspaces/iib:3.16-v4.14-781658- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.16-v4.14-781658- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.16-v4.14-s390x
  + <a href=https://quay.io/devspaces/iib:3.16-v4.13-781660- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.16-v4.13-781660- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.16-v4.13-s390x
  + <a href=https://quay.io/devspaces/iib:3.16-v4.12-781659- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.16-v4.12-781659- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.16-v4.12-s390x
+ x86_64-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.16-v4.16-781663- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.16-v4.16-781663- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.16-v4.16-x86_64
  + <a href=https://quay.io/devspaces/iib:3.16-v4.15-781662- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.16-v4.15-781662- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.16-v4.15-x86_64
  + <a href=https://quay.io/devspaces/iib:3.16-v4.14-781658- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.16-v4.14-781658- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.16-v4.14-x86_64
  + <a href=https://quay.io/devspaces/iib:3.16-v4.13-781660- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.16-v4.13-781660- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.16-v4.13-x86_64
  + <a href=https://quay.io/devspaces/iib:3.16-v4.12-781904- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.16-v4.12-781904- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.16-v4.12-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.16-v4.16-781663- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.16-v4.16-781663- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.16-v4.16-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.16-v4.15-781662- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.16-v4.15-781662- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.16-v4.15-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.16-v4.14-781658- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.16-v4.14-781658- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.16-v4.14-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.16-v4.13-781903- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.16-v4.13-781903- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.16-v4.13-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.16-v4.12-781904- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.16-v4.12-781904- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.16-v4.12-ppc64le

@dmytro-ndp
Copy link
Contributor

@akurinnoy: FYI: I tested PR in Dev Spaces 3.15 with Che Dashboard quay.io/eclipse/che-dashboard:pr-1155 deployed to the ROSA 4.16 cluster by creating several workspaces from "User Dashboard -> Create Workspace" page, stopped workspace in parallel when start workspace - all worked good. No unexpected status change from Starting to Stopped with Status changed unexpectedly to "Stopped" warning message were been observed.
Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants