fix: replace namespace and app name with placeholders for #2586 #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#2586 Signed-off-by: David Kwon <dakwon@redhat.com>
Signed-off-by: David Kwon <dakwon@redhat.com>
dkwon17
requested review from
rkratky,
max-cx,
deerskindoll and
a team
as code owners
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
|
🎊 Navigate the preview: https://644a6208702b3d042916582b--eclipse-che-docs-pr.netlify.app 🎊 |
tolusha
approved these changes
Apr 26, 2023
max-cx
approved these changes
Apr 26, 2023
max-cx
pushed a commit
that referenced
this pull request
Apr 26, 2023
* fix: replace namespace and app name with placeholders for #2586 Signed-off-by: David Kwon <dakwon@redhat.com> * Add role and rolebinding to dwo operators metrics setup Signed-off-by: David Kwon <dakwon@redhat.com> --------- Signed-off-by: David Kwon <dakwon@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the service monitor for Che Server:
Before:
After:
What does this pull request change?
The second commit adds a role and rolebinding similar step 2 of the che server monitoring docs
What issues does this pull request fix or reference?
Small fix and something I realize could be helpful (role & rolebinding) for #2586
Specify the version of the product this pull request applies to
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.