Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Che 7 stack: Java + MySQL #11809

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Add Che 7 stack: Java + MySQL #11809

merged 2 commits into from
Nov 5, 2018

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Nov 2, 2018

What does this PR do?

Adds Che 7 stack with Java 8 and MySQL database.
Theia IDE added as a plugin by default.

What issues does this PR fix or reference?

redhat-developer/rh-che#994

@mmorhun
Add Che 7 stack: Java + MySQL
6ad07c4 
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun mmorhun self-assigned this Nov 2, 2018
@mmorhun
Copy link
Contributor Author

mmorhun commented Nov 2, 2018 •
edited
Loading

Because of problem with volumes on openshift.io I cannot fully test it, because build fails with errors like:

INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3.141 s
[INFO] Finished at: 2018-11-02T08:33:25+00:00
[INFO] Final Memory: 9M/20M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:2.6:resources (default-resources) on project spring-petclinic: Failed to copy full contents from /projects/web-java-spring-petclinic/src/main/resources/dandelion/datatables/datatables.properties to /projects/web-java-spring-petclinic/target/classes/dandelion/datatables/datatables.properties -> [Help 1]

However I managed to start petclinic sample project (checkout to mysql branch) and add records into database.

@benoitf
Copy link
Contributor

benoitf commented Nov 2, 2018

if it's in upstream che, shouldn't all the stacks be compliant with kubernetes and openshift ? here it seems it is only for openshift

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Nov 2, 2018
@sleshchenko
Copy link
Member

if it's in upstream che, shouldn't all the stacks be compliant with kubernetes and openshift ? here it seems it is only for openshift

Good point. @mmorhun You can change openshift type to kubernetes and then it will work for both ( K8s and OS infrastructures). P.S. Don't forget to remove openshift word from stack name as well.

@mmorhun
Copy link
Contributor Author

mmorhun commented Nov 2, 2018 •
edited
Loading

@sleshchenko @benoitf I decided to go with one stack of kubernetes recipe type because it doesn't contains any openshift specific features and therefore will work on both.

@mmorhun
Copy link
Contributor Author

mmorhun commented Nov 2, 2018

@l0rd @slemeur it will not work until the problem with volumes resolved (unless workaround it in non user friendly way: clone the petclinic project outside volume, build and run).

sleshchenko
sleshchenko reviewed Nov 5, 2018
View reviewed changes
ide/che-core-ide-stacks/src/main/resources/stacks.json
}
},
{
"commandLine": "cd ${current.project.path}/target/ && cp *.war ${TOMCAT_HOME}/webapps/ROOT.war",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command won't work with Theia, right?

Copy link
Contributor Author

@mmorhun mmorhun Nov 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will if user selects a project in Files panel.

ide/che-core-ide-stacks/src/main/resources/stacks.json Show resolved Hide resolved
@mmorhun
Copy link
Contributor Author

mmorhun commented Nov 5, 2018

ci-test

@riuvshin
Copy link
Contributor

riuvshin commented Nov 5, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11809
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@mmorhun mmorhun merged commit 2921433 into master Nov 5, 2018
@mmorhun mmorhun deleted the rhche-944-java-mysql branch November 5, 2018 13:37
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 5, 2018
@benoitf benoitf added this to the 6.14.0 milestone Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@l0rd l0rd l0rd approved these changes

@musienko-maxim musienko-maxim musienko-maxim approved these changes

@sleshchenko sleshchenko sleshchenko approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@evidolob evidolob Awaiting requested review from evidolob

@ashumilova ashumilova Awaiting requested review from ashumilova

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

Assignees

@mmorhun mmorhun

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
6.14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@mmorhun @benoitf @sleshchenko @riuvshin @l0rd @musienko-maxim @AndrienkoAleksandr