CHE-1146 Factory jpa integration and structural refactoring #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @param update | ||
| * factory update | ||
| * @return updated factory with links |
There was a problem hiding this comment.
are you sure that manager'll return factory with links
|
|
|
ok |
|
|
||
| /** | ||
| * Convert legacy factory parameter to new the latest format | ||
| * | ||
| * @author Alexander Garagatyi | ||
| */ | ||
| public interface LegacyConverter { | ||
| void convert(Factory factory) throws ApiException; | ||
| void convert(FactoryDto factory) throws ApiException; |
There was a problem hiding this comment.
Maybe it should use FactoryImpl instead of dto?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds factory model objects, dtos, impls;
Adds factory manager;
Reworks factory dao interface;
Adds a new FactoryDao implementation based on JPA;
Adds tests for FactoryDao interface contract(TCKs).
What issues does this PR fix or reference?
codenvy/codenvy#392
Tests written?
Yes
@skabashnyuk, @evoevodin, @sleshchenko please review