[Test] Save events from failed workspaces in load-tests script #22888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkorikSergey
added
status/code-review
dmytro-ndp
reviewed
Mar 22, 2024
dmytro-ndp
reviewed
Mar 22, 2024
| kubectl describe dw dw$i >logs/dw$i-log.log | ||
| kubectl logs $(kubectl get dw dw$i --template='{{.status.devworkspaceId}}') >logs/dw$i-pod.log || true | ||
| cat logs/events.log | grep $ws_name >logs/dw$i-events.log | ||
| kubectl logs $ws_name >logs/dw$i-pod.log || true |
There was a problem hiding this comment.
There was a problem hiding this comment.
Not the same. Get events in 95 line saves all events to file. And after that all failed pod logs getting from events file. It saves time - don't need to ask Openshift cluster for events of every failed workspace(just once).
There was a problem hiding this comment.
I meant, the same comment as for https://github.com/eclipse/che/pull/22888/files#r1535549399
Sorry for confusion.
dmytro-ndp
reviewed
Mar 22, 2024
| @@ -107,8 +110,10 @@ function runTest() { | |||
| succeeded=$((succeeded + 1)) | |||
| else | |||
| print_error "Timeout waiting for dw$i to become ready or an error occurred." | |||
| ws_name=$(kubectl get dw dw$i --template='{{.status.devworkspaceId}}') | |||
There was a problem hiding this comment.
If devworkspaceId != actual workspace name, then I would recommend to name variable correspondingly as devworkspace_id to avoid confusion.
dmytro-ndp
approved these changes
Mar 22, 2024
SkorikSergey
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Save events from failed workspaces in load-tests script. Events saving takes time but kubectl doen't have command like oc client(
oc get events --since=1h).What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-5633
How to test this PR?
load-test.shscript from test/e2e/performance/load-tests. Set number of started workspaces by -c parameter(like./load-test.sh -c 5)PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.