Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-5555: try to fix occasionally failing tests on CI #5585

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Conversation

garagatyi
Copy link

What does this PR do?

We have very complicated class and tests for it fail occasionally on CI. It is hard to identify problem now and Che 6 probably won't include these tests.
This PR is trying to workaround this problem. It actually disables some code execution using mocking mechanics.

What issues does this PR fix or reference?

May fix #5555

Changelog

Fix occasionally failing tests on CI

Release Notes

Docs PR

Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@garagatyi garagatyi added the kind/bug Outline of a bug - must adhere to the bug report template. label Jul 10, 2017
@garagatyi
Copy link
Author

@benoitf @evoevodin Guys, WDYT about this approach?

@benoitf
Copy link
Contributor

benoitf commented Jul 10, 2017

@garagatyi let's try it

@codenvy-ci
Copy link

Build # 3031 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3031/ to view the results.

@garagatyi garagatyi merged commit b7b756c into master Jul 10, 2017
@garagatyi garagatyi deleted the CHE-5555 branch July 10, 2017 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

org.eclipse.che.plugin.docker.machine.MachineProviderImplTest.setUp test is failing randomly on CI
4 participants