-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support receiving cloud events using HTTP endpoint #889
Milestone
Comments
Cool 👍
private Signal<?> jsonToDittoSignal(final String jsonString) {
final JsonObject jsonObject = JsonObject.of(jsonString);
final JsonifiableAdaptable jsonifiableAdaptable = ProtocolFactory.jsonifiableAdaptableFromJson(jsonObject);
final DittoProtocolAdapter dittoProtocolAdapter = DittoProtocolAdapter.newInstance();
return dittoProtocolAdapter.fromAdaptable(jsonifiableAdaptable);
}
Regarding naming and verb of the new endpoint I would suggest:
|
ctron
added a commit
to ctron/ditto
that referenced
this issue
Nov 24, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
added a commit
to ctron/ditto
that referenced
this issue
Nov 24, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
added a commit
to ctron/ditto
that referenced
this issue
Nov 25, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
added a commit
to ctron/ditto
that referenced
this issue
Nov 26, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
added a commit
to ctron/ditto
that referenced
this issue
Nov 26, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
added a commit
to ctron/ditto
that referenced
this issue
Nov 26, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Signed-off-by: Jens Reimann <jreimann@redhat.com> Co-authored-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
ctron
added a commit
to ctron/ditto
that referenced
this issue
Nov 26, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Co-authored-by: Thomas Jaeckle <thomas.jaeckle@bosch.io> Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
added a commit
to ctron/ditto
that referenced
this issue
Nov 26, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Co-authored-by: Thomas Jaeckle <thomas.jaeckle@bosch.io> Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
added a commit
to ctron/ditto
that referenced
this issue
Nov 26, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Co-authored-by: Thomas Jaeckle <thomas.jaeckle@bosch.io> Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
added a commit
to ctron/ditto
that referenced
this issue
Nov 26, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Co-authored-by: Thomas Jaeckle <thomas.jaeckle@bosch.io> Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
added a commit
to ctron/ditto
that referenced
this issue
Nov 26, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Co-authored-by: Thomas Jaeckle <thomas.jaeckle@bosch.io> Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
added a commit
to ctron/ditto
that referenced
this issue
Nov 26, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Co-authored-by: Thomas Jaeckle <thomas.jaeckle@bosch.io> Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
added a commit
to ctron/ditto
that referenced
this issue
Nov 27, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Co-authored-by: Thomas Jaeckle <thomas.jaeckle@bosch.io> Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
added a commit
to ctron/ditto
that referenced
this issue
Nov 27, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Co-authored-by: Thomas Jaeckle <thomas.jaeckle@bosch.io> Signed-off-by: Jens Reimann <jreimann@redhat.com>
thjaeckle
added a commit
to ctron/ditto
that referenced
this issue
Nov 30, 2020
* set response-required=false and requested-acks=twin-persisted via DittoHeadersBuilder (accept cloudevent requests with a 202 once persisted) * undid initializing DittoProtocolAdapter in a special way as this is not required * fixed that AbstractShardedPersistenceActor did not send back errors when response-required=false and requested-acks=twin-persisted was set in combination * applied codeformatter / organized imports * adjusted log statements to contain "CloudEvent" * adjusted some javadocs Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
thjaeckle
added a commit
to ctron/ditto
that referenced
this issue
Nov 30, 2020
…alculated headers e.g. containing authentication information Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
thjaeckle
added a commit
that referenced
this issue
Dec 1, 2020
[#889]: Implement cloud events HTTP endpoint
ctron
added a commit
to ctron/ditto
that referenced
this issue
Dec 4, 2020
This change adds support for receiving cloud events through the HTTP binding. The event's payload must be in the Ditto Protocol JSON. Co-authored-by: Thomas Jaeckle <thomas.jaeckle@bosch.io> Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
pushed a commit
to ctron/ditto
that referenced
this issue
Dec 4, 2020
* set response-required=false and requested-acks=twin-persisted via DittoHeadersBuilder (accept cloudevent requests with a 202 once persisted) * undid initializing DittoProtocolAdapter in a special way as this is not required * fixed that AbstractShardedPersistenceActor did not send back errors when response-required=false and requested-acks=twin-persisted was set in combination * applied codeformatter / organized imports * adjusted log statements to contain "CloudEvent" * adjusted some javadocs Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
ctron
pushed a commit
to ctron/ditto
that referenced
this issue
Dec 4, 2020
…alculated headers e.g. containing authentication information Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
I would close this as the basic functionality is available via #895 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think it makes sense for Ditto to support receiving Ditto Protocol JSON messages also via Cloud Events.
While cloud events provide bindings for Kafka, MQTT, … they also have an HTTP endpoint binding, which can easily be used in the combination with Knative. So it would be possible, to easily map incoming messages from any Knative eventing source, to Ditto, acting as a Knative eventing sink.
The payload of these events would be expected to be "Ditto Protocol payload (JSON)".
I would be volunteering to work on this.
The text was updated successfully, but these errors were encountered: