Bugfix for AMQP 0.9.1 reconnected state #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Fendt <Florian.Fendt@bosch-si.com>
…happens when a Connection receives an external message Signed-off-by: Florian Fendt <Florian.Fendt@bosch-si.com>
# Conflicts: # services/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/MessageMappingProcessorActor.java # services/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/ReconnectActor.java
…nnect to the broker Signed-off-by: Florian Fendt <Florian.Fendt@bosch-si.com>
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #228 which describes the problem that AMQP 0.9.1 connections can't consume or publish if the connection had to reconnect to the broker.
The library used to establish the connections to AMQP 0.9.1 provides failover and notifies us after a reconnect with the new created channels. With this PR, the actors responsible for consuming and publishing will use the new channels.
While trying to find the issue itself, i realized that we should have some more logging which is why i also added some more log messages.