Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax timing requirement in MongoEventSourceITAssertions. #927

Merged
merged 3 commits into from
Dec 23, 2020

Conversation

yufei-cai
Copy link
Contributor

Relax timing requirement so that the MongoDB integration tests fail less often on slow systems.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
@yufei-cai
Copy link
Contributor Author

@thjaeckle License header year checking is not working.

Run jitterbit/get-changed-files@v1
Base commit: cf1a678e6ee47f746932055b6fbb460e83ce0c98
Head commit: cba015eb36ca68d0c19d71d93f6e69bfbff1e7bb
Error: The head commit for this pull_request event is not ahead of the base commit. Please submit an issue on this action's GitHub repo.
All: services/utils/persistence/src/test/java/org/eclipse/ditto/services/utils/persistence/mongo/ops/eventsource/MongoEventSourceITAssertions.java
Added: 
Modified: services/utils/persistence/src/test/java/org/eclipse/ditto/services/utils/persistence/mongo/ops/eventsource/MongoEventSourceITAssertions.java
Removed: 
Renamed: 
Added or modified: services/utils/persistence/src/test/java/org/eclipse/ditto/services/utils/persistence/mongo/ops/eventsource/MongoEventSourceITAssertions.java

@thjaeckle
Copy link
Member

thjaeckle commented Dec 22, 2020

@yufei-cai oh, bad .. then just remove the action for now on this branch and merge it - I'll have a look once I'm back.
The issue seems to be known: jitterbit/get-changed-files#7

Edit:
That could also work:

- uses: jitterbit/get-changed-files@v1
   id: the-files
   continue-on-error: true

@yufei-cai yufei-cai added this to the 2.0.0 milestone Dec 23, 2020
@yufei-cai
Copy link
Contributor Author

@thjaeckle Does Github actions require special permissions? I get 404 when I try to view or edit the action yaml.

@thjaeckle
Copy link
Member

@yufei-cai it's just a file in the .github folder top level. Maybe your branch has not yet merged the commit in which I added the file?

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
@jokraehe jokraehe merged commit 510e3ae into eclipse-ditto:master Dec 23, 2020
@jokraehe jokraehe deleted the bugfix/mongo-it-timing branch December 23, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants