Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bugs with expanded Json-ld formats #2955

Merged
merged 1 commit into from
May 11, 2023

Conversation

jimmarino
Copy link
Contributor

What this PR changes/adds

Fixes issues when transforming expanded Json for contract negotiation.

Further notes

Starts to introduce expanding Json in Json-ld transformer unit tests to avoid these problems in the future. Additional PRs will resolve issues in the other Json-ld transformers as well as improve error messages.

Linked Issue(s)

Closes #2919

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@jimmarino jimmarino added bug Something isn't working dataspace-protocol related to the dataspace protocol labels May 11, 2023
@jimmarino jimmarino marked this pull request as ready for review May 11, 2023 11:35
@jimmarino jimmarino temporarily deployed to Azure-dev May 11, 2023 11:35 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 63.63% and project coverage change: -0.39 ⚠️

Comparison is base (61669db) 66.46% compared to head (394cb11) 66.08%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2955      +/-   ##
==========================================
- Coverage   66.46%   66.08%   -0.39%     
==========================================
  Files        1036     1038       +2     
  Lines       21059    21210     +151     
  Branches     1234     1255      +21     
==========================================
+ Hits        13997    14016      +19     
- Misses       6542     6673     +131     
- Partials      520      521       +1     
Impacted Files Coverage Δ
...tractNegotiationTerminationMessageTransformer.java 81.25% <50.00%> (+1.25%) ⬆️
...JsonObjectToContractRequestMessageTransformer.java 73.33% <60.00%> (+0.60%) ⬆️
...nld/spi/transformer/AbstractJsonLdTransformer.java 13.07% <64.00%> (ø)
...onObjectToContractAgreementMessageTransformer.java 73.07% <100.00%> (+1.37%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jimmarino jimmarino merged commit 780daed into eclipse-edc:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dataspace-protocol related to the dataspace protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dsp: JsonObjectToContractAgreementMessageTransformer fails mapping ContractAgreement
4 participants