Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor IATP Credential validation into separate service #4107

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Apr 11, 2024

What this PR changes/adds

Separates the cryptographic verification of VPs and VCs and the subsequent checking of several rules into a lower level aggregate service called VerifiableCredentialValidationService.

This reduces the number of collaborators needed by the IdentityAndTrustService and keeps concerns neatly confined.

Why it does that

The main reason for this is that this new service can then be used independently from IATP, e.g. for stand-alone validation of a VP.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added refactoring Cleaning up code and dependencies iatp labels Apr 11, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.14286% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.69%. Comparing base (7f20ba5) to head (bc27331).
Report is 211 commits behind head on main.

Files Patch % Lines
...als/spi/VerifiableCredentialValidationService.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4107      +/-   ##
==========================================
+ Coverage   71.74%   74.69%   +2.94%     
==========================================
  Files         919      981      +62     
  Lines       18457    20098    +1641     
  Branches     1037     1132      +95     
==========================================
+ Hits        13242    15012    +1770     
+ Misses       4756     4592     -164     
- Partials      459      494      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger force-pushed the feat/refactor_credential_validation branch from bc27331 to c1ceea8 Compare April 11, 2024 09:14
@paullatzelsperger paullatzelsperger marked this pull request as ready for review April 11, 2024 10:01
@paullatzelsperger paullatzelsperger merged commit bbcdabe into eclipse-edc:main Apr 11, 2024
18 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/refactor_credential_validation branch April 11, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iatp refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants