Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move IATP Transformer Extension into IATP module #4110

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Apr 11, 2024

What this PR changes/adds

Moves the IdentityAndTrustTransformExtension into the identitytrust-core module.

Why it does that

to be able to use several of the VP/VC transformers independently of IATP and of each other.

Further notes

makes the rule that checks the audience optional, and only validates if the expected audience is non-null.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the refactoring Cleaning up code and dependencies label Apr 11, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 66.58%. Comparing base (7f20ba5) to head (aea2674).
Report is 212 commits behind head on main.

Files Patch % Lines
...fiablecredentials/jwt/JwtPresentationVerifier.java 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4110      +/-   ##
==========================================
- Coverage   71.74%   66.58%   -5.16%     
==========================================
  Files         919      981      +62     
  Lines       18457    20101    +1644     
  Branches     1037     1132      +95     
==========================================
+ Hits        13242    13385     +143     
- Misses       4756     6259    +1503     
+ Partials      459      457       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit 885936f into eclipse-edc:main Apr 11, 2024
16 checks passed
@paullatzelsperger paullatzelsperger deleted the chore/move_vp_vc_transformer_extension branch April 11, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants