Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Iron VC to 0.14.0 #4125

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

this PR updates our implementation of the JsonWebKey2020Signature suite to the new API of the iron-verifiable-credentials library v0.14.0.

Why it does that

Avoid technical debt

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4066

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 64.62094% with 98 lines in your changes are missing coverage. Please review.

Project coverage is 74.70%. Comparing base (7f20ba5) to head (6640e11).
Report is 223 commits behind head on main.

Files Patch % Lines
...lecredentials/linkeddata/DataIntegrityKeyPair.java 0.00% 26 Missing ⚠️
.../verifiablecredentials/linkeddata/LdpVerifier.java 66.66% 11 Missing and 12 partials ⚠️
...e/edc/security/signature/jws2020/Jws2020Proof.java 73.91% 7 Missing and 5 partials ⚠️
...ipse/edc/security/signature/jws2020/JwsIssuer.java 58.33% 6 Missing and 4 partials ⚠️
.../security/signature/jws2020/Jwk2020KeyAdapter.java 80.00% 4 Missing and 4 partials ⚠️
.../security/signature/jws2020/Jws2020ProofDraft.java 83.33% 4 Missing and 1 partial ⚠️
...urity/signature/jws2020/Jws2020SignatureSuite.java 75.00% 2 Missing and 3 partials ⚠️
...dc/verifiablecredentials/linkeddata/LdpIssuer.java 72.72% 3 Missing ⚠️
...iablecredentials/linkeddata/DidMethodResolver.java 0.00% 2 Missing ⚠️
...se/edc/security/signature/jws2020/JsonAdapter.java 33.33% 2 Missing ⚠️
... and 2 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4125      +/-   ##
==========================================
+ Coverage   71.74%   74.70%   +2.95%     
==========================================
  Files         919      986      +67     
  Lines       18457    20305    +1848     
  Branches     1037     1148     +111     
==========================================
+ Hits        13242    15168    +1926     
+ Misses       4756     4636     -120     
- Partials      459      501      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Apr 20, 2024
@paullatzelsperger paullatzelsperger force-pushed the feat/upgrade_jws2020_to_iron_0.14.0 branch from bde38e0 to da4bf3f Compare April 20, 2024 09:25
@paullatzelsperger paullatzelsperger marked this pull request as ready for review April 20, 2024 11:05
@paullatzelsperger paullatzelsperger merged commit 4ed1f99 into eclipse-edc:main Apr 22, 2024
16 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/upgrade_jws2020_to_iron_0.14.0 branch April 22, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(vc): update iron-verifiable-credentials to version 0.14.0
3 participants