Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add supportedType method on source and sink factories #4151

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented May 2, 2024

What this PR changes/adds

Add supportedType on DataSourceFactory and DataSinkFactory

Why it does that

permit the dataplane to tell which sources/sinks it can handle

Further notes

  • deprecated the now unused canHandle

Linked Issue(s)

Closes #4150

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label May 2, 2024
@ndr-brt ndr-brt added the dpf Feature related to the Data Plane Framework label May 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.89%. Comparing base (7f20ba5) to head (d3600b5).
Report is 398 commits behind head on main.

Files Patch % Lines
...dataplane/kafka/pipeline/KafkaDataSinkFactory.java 0.00% 1 Missing ⚠️
...taplane/kafka/pipeline/KafkaDataSourceFactory.java 0.00% 1 Missing ⚠️
...nector/dataplane/spi/pipeline/DataSinkFactory.java 0.00% 1 Missing ⚠️
...ctor/dataplane/spi/pipeline/DataSourceFactory.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4151      +/-   ##
==========================================
+ Coverage   71.74%   74.89%   +3.15%     
==========================================
  Files         919      988      +69     
  Lines       18457    20282    +1825     
  Branches     1037     1142     +105     
==========================================
+ Hits        13242    15191    +1949     
+ Misses       4756     4593     -163     
- Partials      459      498      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit d6b055c into eclipse-edc:main May 6, 2024
19 of 20 checks passed
@ndr-brt ndr-brt deleted the 4150-add-supported-type-method branch May 6, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dpf Feature related to the Data Plane Framework enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give to the dataplane a way to know which transferTypes can handle
3 participants