Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move configuration loading logic out of the extension context #4162

Merged
merged 3 commits into from
May 8, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented May 6, 2024

What this PR changes/adds

Add new ConfigurationLoader component that takes care of configuration loading (as ExtensionLoader is doing for extensions).

Why it does that

refactor

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4158

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label May 6, 2024
@ndr-brt ndr-brt requested a review from wolf4ood May 6, 2024 13:48
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.02%. Comparing base (7f20ba5) to head (3ac720a).
Report is 246 commits behind head on main.

Files Patch % Lines
...junit/extensions/DependencyInjectionExtension.java 0.00% 1 Missing ⚠️
.../junit/extensions/TestServiceExtensionContext.java 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4162      +/-   ##
==========================================
+ Coverage   71.74%   75.02%   +3.27%     
==========================================
  Files         919     1007      +88     
  Lines       18457    20453    +1996     
  Branches     1037     1151     +114     
==========================================
+ Hits        13242    15344    +2102     
+ Misses       4756     4608     -148     
- Partials      459      501      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit b86175a into eclipse-edc:main May 8, 2024
16 checks passed
@ndr-brt ndr-brt deleted the 4158-move-config-load branch May 8, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: move loadConfig logic out of DefaultServiceExtensionContext
4 participants