-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add version endpoint #4196
feat: add version endpoint #4196
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4196 +/- ##
==========================================
+ Coverage 71.74% 75.23% +3.49%
==========================================
Files 919 1015 +96
Lines 18457 20622 +2165
Branches 1037 1161 +124
==========================================
+ Hits 13242 15515 +2273
+ Misses 4756 4593 -163
- Partials 459 514 +55 ☔ View full report in Codecov by Sentry. |
Let's discuss this. I want to align what we do here with the approach to versioning endpoints in DSP, which is not to say this is un-aligned. I'd like to make sure we have a wholistic approach and a DR for it. |
However, the D-R does not go into details on how the version information is to be stored (obviously it has to be a file). To me, the more valuable feature is the CI check anyways, and it took way more time to get quite right (GitHub is a bit picky with git checkouts). I'm less worried about what the URL path or the response schema is but this is the reason it is still in draft :) |
2164238
to
1e040cb
Compare
I'm referring to version discoverability similar to what DSP has. We can discuss. |
299566e
to
58845ed
Compare
df07a8e
to
97ad718
Compare
e516d81
to
7553f7c
Compare
What this PR changes/adds
This PR adds several things:
ApiVersionService
that API modules/.well-known/api/v1/version
An example of such a check is here:
https://github.com/paullatzelsperger/DataSpaceConnector/actions/runs/9141255716/job/25135444163
Why it does that
client information
Further notes
The check
Verify-Api-Version
is quite crude now, for example it does not assert that the version was actually incremented or, that the date string is plausible. Let's see how far we get and improve from there.Linked Issue(s)
Closes #4181
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.