Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct null check message to corresponding field #4251

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

domreuter
Copy link
Contributor

What this PR changes/adds

This PR corrects the null check error message for the providerId within the EDREntry.

Why it does that

Wrong validation message was given for the providerId field.

Linked Issue(s)

Closes #4250

@wolf4ood wolf4ood added the bug Something isn't working label Jun 7, 2024
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the formatting and it should be good

Thanks

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.03%. Comparing base (7f20ba5) to head (bb81a28).
Report is 296 commits behind head on main.

Current head bb81a28 differs from pull request most recent head a3665a5

Please upload reports for the commit a3665a5 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #4251       +/-   ##
============================================
- Coverage     71.74%   6.03%   -65.71%     
- Complexity        0     394      +394     
============================================
  Files           919    1046      +127     
  Lines         18457   20980     +2523     
  Branches       1037    1169      +132     
============================================
- Hits          13242    1267    -11975     
- Misses         4756   19692    +14936     
+ Partials        459      21      -438     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@domreuter domreuter requested a review from wolf4ood June 7, 2024 11:47
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wolf4ood wolf4ood merged commit f374ea1 into eclipse-edc:main Jun 7, 2024
16 checks passed
@domreuter domreuter deleted the chore/edr_entry_validation branch June 7, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EndpointDataReferenceEntry: null check for providerId refers to the wrong message
4 participants