feat: add v3.1.0-alpha of the Managemenet API #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
bug
|
FYI @saschaisele-zf |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4343 +/- ##
==========================================
+ Coverage 71.74% 75.30% +3.56%
==========================================
Files 919 1053 +134
Lines 18457 21169 +2712
Branches 1037 1182 +145
==========================================
+ Hits 13242 15942 +2700
+ Misses 4756 4709 -47
- Partials 459 518 +59 ☔ View full report in Codecov by Sentry. |
ndr-brt
reviewed
Jul 9, 2024
...observability/src/main/java/org/eclipse/edc/api/observability/ObservabilityApiExtension.java
Outdated
Show resolved
Hide resolved
ndr-brt
reviewed
Jul 9, 2024
extensions/common/api/management-api-configuration/src/main/resources/mgmt-api-version.json
Outdated
Show resolved
Hide resolved
paullatzelsperger
force-pushed
the
feat/4334_add_v3.1alpha_mgmtapi
branch
from
1611b20
to
9ae09c8
Compare
wolf4ood
approved these changes
Jul 9, 2024
ndr-brt
approved these changes
Jul 9, 2024
| var content = typeManager.getMapper().readValue(versionContent, VersionRecord.class); | ||
| apiVersionService.addRecord(OBSERVABILITY_CONTEXT, content); | ||
| Stream.of(typeManager.getMapper() | ||
| .enable(DeserializationFeature.ACCEPT_SINGLE_VALUE_AS_ARRAY) |
There was a problem hiding this comment.
this is not needed anymore (it doesn't hurt either :) )
ndr-brt
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds an entry in the version JSON file, plus improves the parsing mechanism to parse a
List<VersionRecord>.Why it does that
Preparation for #3961 and #4322
Further notes
version.jsonfiles overwrote one another, b/c they're all on the same classpath. I gave them each individual namesLinked Issue(s)
Closes #4334
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.