Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Missing Pages, Broken Links, 404 Errors #153

Closed
mhellmeier opened this issue Jun 4, 2024 · 6 comments · Fixed by #156
Closed

Missing Pages, Broken Links, 404 Errors #153

mhellmeier opened this issue Jun 4, 2024 · 6 comments · Fixed by #156
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@mhellmeier
Copy link

mhellmeier commented Jun 4, 2024

Bug Report

Describe the Bug

(This is just one example. See the comments for further pages and infos.)

The following page is shown in the menu ("Best Practices") but leads to a "Page not found" error:
https://eclipse-edc.github.io/docs/#/submodule/Connector/docs/developer/best-practices

Expected Behavior

A best practices page is shown.

Observed Behavior

A 404 error is shown.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Visit https://eclipse-edc.github.io/docs/#/submodule/Connector/docs/developer/best-practices
  2. See error

Context Information

Add any other context about the problem here.

Detailed Description

./.

Possible Implementation

./.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Thanks for your contribution 🔥 We will take a look asap 🚀

@mhellmeier mhellmeier changed the title Best Practices Page Missing Best Practices Page Missing + Different Broken Links Jun 4, 2024
@mhellmeier
Copy link
Author

mhellmeier commented Jun 4, 2024

@mhellmeier mhellmeier changed the title Best Practices Page Missing + Different Broken Links Missing Pages, Broken Links, 404 Errors Jun 4, 2024
@ndr-brt ndr-brt added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jun 4, 2024
@ndr-brt
Copy link
Member

ndr-brt commented Jun 4, 2024

thanks for reporting, yes, a lot of links definitely need some love

@ndr-brt
Copy link
Member

ndr-brt commented Jun 10, 2024

Different links are also broken in the documentation. Some examples:

not all of them, only the ones that miss the trailing slash, this is a docsify issue, but I'm not sure it will be ever solved:
docsifyjs/docsify#1018

these 404 are given by the fact that these projects don't contain either docs/developer/README.md file or docs/developer/decision-records/README.md

@mhellmeier
Copy link
Author

This Issue needs to be reopened since the problem is still present because most of the links mentioned here still don't work.

@ndr-brt
Copy link
Member

ndr-brt commented Jun 14, 2024

This Issue needs to be reopened since the problem is still present because most of the links mentioned here still don't work.

these are issues to be addressed in the related repos, nothing can be done here.
one was already solved in the connector one: eclipse-edc/Connector#4257

(please note that the update of the submodules docs happens once in a week, on monday)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants