Remove parent nucleus-parent for docs pom.xml to fix the build #23733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix the Jenkins build job for docs, which gives "Could not find artifact org.glassfish.main:nucleus-parent:zip:resources:7.0.0-SNAPSHOT". Nothing from nucleus-parent is needed to build the docs and the parent isn't built together with the docs module, giving an error in the Jenkins job.
OndroMih
changed the title
dmatej
requested changes
Dec 10, 2021
There was a problem hiding this comment.
If you change parents you have to add the plugin-management and define missing plugin versions. It seems it is just two plugins, so it should be simple.
[WARNING] Some problems were encountered while building the effective model for org.glassfish.docs:add-on-component-development-guide:jar:7.0.0-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-jar-plugin is missing. @ org.glassfish.docs:parent:7.0.0-SNAPSHOT, /media/data-samsung/data/dmatej/work/repo/git/glassfish-beta/docs/parent/pom.xml, line 183, column 21
[WARNING] 'build.plugins.plugin.version' for org.codehaus.mojo:build-helper-maven-plugin is missing. @ org.glassfish.docs:parent:7.0.0-SNAPSHOT, /media/data-samsung/data/dmatej/work/repo/git/glassfish-beta/docs/parent/pom.xml, line 162, column 21
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.glassfish.docs:administration-guide:jar:7.0.0-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-jar-plugin is missing. @ org.glassfish.docs:parent:7.0.0-SNAPSHOT, /media/data-samsung/data/dmatej/work/repo/git/glassfish-beta/docs/parent/pom.xml, line 183, column 21
[WARNING] 'build.plugins.plugin.version' for org.codehaus.mojo:build-helper-maven-plugin is missing. @ org.glassfish.docs:parent:7.0.0-SNAPSHOT, /media/data-samsung/data/dmatej/work/repo/git/glassfish-beta/docs/parent/pom.xml, line 162, column 21
After the nucleus-parent that defined them in plaugin management was removed as a parent.
OndroMih
force-pushed
the
fix-docs-parent
branch
from
5a15830
to
237c56b
Compare
dmatej
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the Jenkins build job for docs, which gives "Could not find artifact org.glassfish.main:nucleus-parent:zip:resources:7.0.0-SNAPSHOT": https://ci.eclipse.org/glassfish/view/all/job/glassfish-docs-publish/507/console
Nothing from nucleus-parent is needed to build the docs and the parent isn't built together with the docs module, giving an error in the Jenkins job.
This PR also adds the missing news about the 6.2.3 release to the website.