-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 23739 Fixed documentation syntax, using only Asciidoctor, JBake removed #23741
Merged
arjantijms
merged 34 commits into
eclipse-ee4j:master
from
dmatej:issue-23739-asciidoc-fixes
Dec 21, 2021
Merged
Issue 23739 Fixed documentation syntax, using only Asciidoctor, JBake removed #23741
arjantijms
merged 34 commits into
eclipse-ee4j:master
from
dmatej:issue-23739-asciidoc-fixes
Dec 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndroMih
approved these changes
Dec 12, 2021
dmatej
force-pushed
the
issue-23739-asciidoc-fixes
branch
6 times, most recently
from
December 17, 2021 08:54
07d1264
to
98c7f64
Compare
…highlighter Signed-off-by: David Matějček <dmatej@seznam.cz>
- this pdf seems quite worthless to me ...
…n html and pdf
… Java EE to Jakarta EE
- previous was extremely sensitive to the length of the test above - this change was done by a set of regular expressions, I hope I did not miss something. - I am committing also toc files as they are helpful to detect any broken chapter header in diff - plus: this syntax is colored by the Eclipse Editor
dmatej
force-pushed
the
issue-23739-asciidoc-fixes
branch
from
December 20, 2021 13:52
ea20954
to
dbccabf
Compare
- jbake maven plugin not required any more
…structural changes
dmatej
changed the title
Issue 23739 Asciidoc Fixes
Issue 23739 Fixed documentation syntax, using only Asciidoctor, JBake removed
Dec 20, 2021
- deleted several block which are not valid any more - repklaced 6/8 by 11, however left 6 where it would mean rewriting the chapter
arjantijms
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After @OndroMih fixed some things in docs build, I noticed that asciidoc prints many warnings, the build is pretty slow and produces broken PDF files. Those PDF files are broken even in the old 5.1 version.
I tried to avoid updating documentation content, but as it affected results, on many places I did some changes. As we need to improve it much faster and do really huge progress asap, I finally resigned and fixed whatever I saw incorrect. So ...
=/-/~/^/+
underline by[=]+
prefixes (not sensitive to the length of the underlined text){productName}
property where possible