Fix #23772 The create-file-user subcommand with passwordfile option isn't usable in embedded glassfish.

[kosakak]

• Fixes The create-file-user subcommand with passwordfile option isn't usable in embedded glassfish. #23772

There is a bug in the process of getting the password value from the loaded password file.

In the process of create-file-user subcommand, CLIUtil.readPasswordFileOptions() is called in CommandExecutorImple.getParameters(). Since the second argument of this method is always true, keys of the map passwords have the prefix "AS_ADMIN_".

glassfish/nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/embeddable/CommandExecutorImpl.java

Line 101 in 4d6a8b5

Map<String, String> passwords = CLIUtil.readPasswordFileOptions(pwfile, true);

For example, if the contents of the passward file is as follows, the key of the user password in the map passwords is "AS_ADMIN_USERPASSWORD".

AS_ADMIN_USERPASSWORD=mypassword

On the other hand, the variable pwdname, which is the key to get the user password from the map passwords, is "userpassword".
Therefore, passwords.get(pwdname) always returns null.

glassfish/nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/embeddable/CommandExecutorImpl.java

Lines 104 to 108 in 4d6a8b5

	String pwdname = opt.getName();
	String pwd = passwords.get(pwdname);
	if (pwd != null) {
	options.set(pwdname, pwd);
	}

I think the second argument of CLIUtil.readPasswordFileOptions() should be false here. With this fix, keys of the map passwords are no longer prefixed with "AS_ADMIN_", and converted to lowercase. (If the password file is the above example, the key of the map passwords is "userpassword")

glassfish/nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/CLIUtil.java

Lines 57 to 58 in 4d6a8b5

	final String optionName = withPrefix ? entry
	: entry.substring(Environment.getPrefix().length()).toLowerCase(Locale.ENGLISH);

Signed-off-by: kosakak kosaka.koki@fujitsu.com

[glassfish-bot]

Can one of the admins verify this patch?